Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
57 | 0 | 0 | 2393 |
Files
org/opensciencegrid/authz/client/GRIDIdentityMappingServiceClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.rmi.RemoteException. |
10
|
| Unused import - org.opensciencegrid.authz.stubs.AuthorizationServiceLocator. |
15
|
| Unused import - org.opensciencegrid.authz.stubs.SAMLRequestPortType. |
16
|
| Unused import - org.opensciencegrid.authz.stubs.SAMLRequestType. |
17
|
| Unused import - org.opensciencegrid.authz.stubs.SAMLResponseType. |
18
|
| Line has trailing spaces. |
24
|
| Line is longer than 80 characters. |
30
|
| Line has trailing spaces. |
31
|
| Missing a Javadoc comment. |
32
|
| Variable 'serviceLocation' must be private and have accessor methods. |
32
|
| Line has trailing spaces. |
33
|
| Line is longer than 80 characters. |
33
|
| Missing a Javadoc comment. |
33
|
| Variable 'log' must be private and have accessor methods. |
33
|
| Line is longer than 80 characters. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter serviceLocation should be final. |
35
|
| 'serviceLocation' hides a field. |
35
|
| First sentence should end with a period. |
40
|
| Expected an @return tag. |
42
|
| Method 'mapCredentials' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Parameter gridID should be final. |
42
|
| Expected @param tag for 'gridID'. |
42
|
| Line has trailing spaces. |
45
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
47
|
| Line has trailing spaces. |
49
|
| Line has trailing spaces. |
51
|
| Line is longer than 80 characters. |
54
|
| Line has trailing spaces. |
57
|
| Line has trailing spaces. |
58
|
| Line is longer than 80 characters. |
58
|
| '(' is followed by whitespace. |
58
|
| Line contains a tab character. |
58
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
59
|
| Line contains a tab character. |
59
|
| Line has trailing spaces. |
60
|
| Line is longer than 80 characters. |
60
|
| Line contains a tab character. |
60
|
| Line is longer than 80 characters. |
61
|
| Line contains a tab character. |
61
|
| Line is longer than 80 characters. |
62
|
| Line contains a tab character. |
62
|
| 'if' is not followed by whitespace. |
64
|
| '!=' is not preceded with whitespace. |
64
|
| '!=' is not followed by whitespace. |
64
|
| Line is longer than 80 characters. |
65
|
| Line has trailing spaces. |
67
|
| '=' is not preceded with whitespace. |
70
|
| '=' is not followed by whitespace. |
70
|
| Line has trailing spaces. |
75
|
org/opensciencegrid/authz/client/SAMLAuthZClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
16
|
| Line is longer than 80 characters. |
17
|
| Unused import - java.util.ArrayList. |
22
|
| Unused import - org.opensaml.v1_0_1.SAMLSubject. |
26
|
| Missing a Javadoc comment. |
32
|
| Utility classes should not have a public or default constructor. |
32
|
| First sentence should end with a period. |
34
|
| Variable 'log' must be private and have accessor methods. |
35
|
| Missing a Javadoc comment. |
37
|
| Parameter args should be final. |
37
|
| Line has trailing spaces. |
38
|
| Line has trailing spaces. |
40
|
| 'if' is not followed by whitespace. |
41
|
| '<' is not preceded with whitespace. |
41
|
| '<' is not followed by whitespace. |
41
|
| Line has trailing spaces. |
42
|
| Line is longer than 80 characters. |
42
|
| Line has trailing spaces. |
49
|
| Line has trailing spaces. |
52
|
| Line has trailing spaces. |
53
|
| 'if' is not followed by whitespace. |
53
|
| '>' is not preceded with whitespace. |
53
|
| '>' is not followed by whitespace. |
53
|
| Line has trailing spaces. |
54
|
| Line is longer than 80 characters. |
58
|
| Line contains a tab character. |
58
|
| Line has trailing spaces. |
60
|
| Line contains a tab character. |
60
|
| Line has trailing spaces. |
61
|
| Line is longer than 80 characters. |
61
|
| Line contains a tab character. |
61
|
| 'if' is not followed by whitespace. |
65
|
| '==' is not preceded with whitespace. |
65
|
| '==' is not followed by whitespace. |
65
|
| '==' is not preceded with whitespace. |
65
|
| '==' is not followed by whitespace. |
65
|
| Line is longer than 80 characters. |
66
|
| '=' is not preceded with whitespace. |
70
|
| '=' is not followed by whitespace. |
70
|
| Line has trailing spaces. |
72
|
| Line is longer than 80 characters. |
73
|
| '+' is not preceded with whitespace. |
73
|
| '+' is not followed by whitespace. |
73
|
| '+' is not preceded with whitespace. |
74
|
| '+' is not followed by whitespace. |
74
|
| Line has trailing spaces. |
75
|
| Line is longer than 80 characters. |
75
|
| '+' is not preceded with whitespace. |
75
|
| '+' is not followed by whitespace. |
75
|
| Line has trailing spaces. |
76
|
| '+' is not preceded with whitespace. |
76
|
| '+' is not followed by whitespace. |
76
|
| Line has trailing spaces. |
77
|
| '+' is not preceded with whitespace. |
77
|
| '+' is not followed by whitespace. |
77
|
| '+' is not preceded with whitespace. |
77
|
| '+' is not followed by whitespace. |
77
|
| '+' is not preceded with whitespace. |
77
|
| '+' is not followed by whitespace. |
77
|
| Line has trailing spaces. |
78
|
| 'if' is not followed by whitespace. |
83
|
| '!=' is not preceded with whitespace. |
83
|
| '!=' is not followed by whitespace. |
83
|
| '>' is not preceded with whitespace. |
83
|
| '>' is not followed by whitespace. |
83
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
95
|
| Line has trailing spaces. |
96
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
98
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
101
|
| '}' should be on the same line. |
103
|
| Line has trailing spaces. |
107
|
| 'catch' is not followed by whitespace. |
109
|
| '+' is not followed by whitespace. |
110
|
| Line has trailing spaces. |
112
|
| Line has trailing spaces. |
114
|
org/opensciencegrid/authz/client/SAMLAuthZClientBase.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
7
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line has trailing spaces. |
22
|
| Line is longer than 80 characters. |
23
|
| Line is longer than 80 characters. |
24
|
| Unused import - java.util.Set. |
29
|
| Unused import - java.util.StringTokenizer. |
31
|
| Unused import - java.security.cert.X509Certificate. |
34
|
| Unused import - javax.security.auth.Subject. |
35
|
| Unused import - org.opensaml.v1_0_1.XML. |
46
|
| Unused import - org.opensaml.v1_0_1.QName. |
47
|
| Unused import - org.opensaml.v1_0_1.SAMLAttributeDesignator. |
58
|
| Missing a Javadoc comment. |
78
|
| First sentence should end with a period. |
81
|
| Line is longer than 80 characters. |
82
|
| Variable 'log' must be private and have accessor methods. |
82
|
| First sentence should end with a period. |
86
|
| Expected an @return tag. |
91
|
| Line is longer than 80 characters. |
91
|
| Method 'getSAMLSubjectFromString' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter subjectName should be final. |
91
|
| Expected @param tag for 'subjectName'. |
91
|
| Expected @throws tag for 'SAMLException'. |
91
|
| 'if' is not followed by whitespace. |
93
|
| '==' is not preceded with whitespace. |
93
|
| '==' is not followed by whitespace. |
93
|
| '==' is not preceded with whitespace. |
93
|
| '==' is not followed by whitespace. |
93
|
| Line has trailing spaces. |
94
|
| Line has trailing spaces. |
97
|
| '+' is not preceded with whitespace. |
98
|
| '+' is not followed by whitespace. |
98
|
| Line has trailing spaces. |
99
|
| Line contains a tab character. |
100
|
| Line is longer than 80 characters. |
101
|
| Line contains a tab character. |
101
|
| Line contains a tab character. |
102
|
| Line has trailing spaces. |
104
|
| Line has trailing spaces. |
105
|
| Line contains a tab character. |
105
|
| Line contains a tab character. |
106
|
| Line contains a tab character. |
108
|
| Line contains a tab character. |
109
|
| Line has trailing spaces. |
110
|
| Line contains a tab character. |
110
|
| Line has trailing spaces. |
111
|
| Line contains a tab character. |
112
|
| Line has trailing spaces. |
114
|
| Line contains a tab character. |
115
|
| First sentence should end with a period. |
120
|
| Expected an @return tag. |
129
|
| Line is longer than 80 characters. |
129
|
| Method 'getSAMLSubjectFromGSS' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Parameter gssContext should be final. |
129
|
| Expected @param tag for 'gssContext'. |
129
|
| Expected @throws tag for 'SAMLException'. |
129
|
| Line has trailing spaces. |
131
|
| '=' is not preceded with whitespace. |
132
|
| '=' is not followed by whitespace. |
132
|
| Line is longer than 80 characters. |
134
|
| '+' is not preceded with whitespace. |
134
|
| '+' is not followed by whitespace. |
134
|
| Line has trailing spaces. |
135
|
| Line contains a tab character. |
136
|
| Line is longer than 80 characters. |
137
|
| Line contains a tab character. |
137
|
| Line contains a tab character. |
138
|
| Line has trailing spaces. |
140
|
| Line has trailing spaces. |
141
|
| Line contains a tab character. |
141
|
| Line contains a tab character. |
142
|
| Line is longer than 80 characters. |
144
|
| Line has trailing spaces. |
146
|
| Line is longer than 80 characters. |
146
|
| Line has trailing spaces. |
147
|
| Line has trailing spaces. |
149
|
| Line contains a tab character. |
150
|
| Line contains a tab character. |
151
|
| Line has trailing spaces. |
152
|
| Line contains a tab character. |
152
|
| Line has trailing spaces. |
153
|
| Line contains a tab character. |
154
|
| Line has trailing spaces. |
156
|
| Line contains a tab character. |
157
|
| Line has trailing spaces. |
161
|
| First sentence should end with a period. |
162
|
| Line is longer than 80 characters. |
163
|
| Expected an @return tag. |
166
|
| Method 'createMappingActions' is not designed for extension - needs to be abstract, final or empty. |
166
|
| Expected @throws tag for 'SAMLException'. |
166
|
| '{' is not preceded with whitespace. |
166
|
| Line is longer than 80 characters. |
169
|
| Line has trailing spaces. |
170
|
| Line contains a tab character. |
170
|
| Line contains a tab character. |
171
|
| Line has trailing spaces. |
172
|
| Line contains a tab character. |
172
|
| Line is longer than 80 characters. |
173
|
| Line contains a tab character. |
173
|
| Line contains a tab character. |
174
|
| Line has trailing spaces. |
181
|
| Line contains a tab character. |
181
|
| Line has trailing spaces. |
184
|
| Line is longer than 80 characters. |
184
|
| Line has trailing spaces. |
185
|
| Expected an @return tag. |
188
|
| Line has trailing spaces. |
188
|
| Line is longer than 80 characters. |
188
|
| Method 'createFQANEvidenceFromString' is not designed for extension - needs to be abstract, final or empty. |
188
|
| Parameter samlSubject should be final. |
188
|
| Expected @param tag for 'samlSubject'. |
188
|
| Parameter fqanIssuer should be final. |
188
|
| Expected @param tag for 'fqanIssuer'. |
188
|
| Parameter fqan should be final. |
188
|
| Expected @param tag for 'fqan'. |
188
|
| Expected @throws tag for 'SAMLException'. |
189
|
| Expected @throws tag for 'CloneNotSupportedException'. |
189
|
| Line has trailing spaces. |
192
|
| Line is longer than 80 characters. |
193
|
| Line is longer than 80 characters. |
194
|
| 'if' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '!=' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '!=' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '!=' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '!=' is not followed by whitespace. |
194
|
| Line has trailing spaces. |
197
|
| Line is longer than 80 characters. |
198
|
| '+' is not preceded with whitespace. |
198
|
| '+' is not followed by whitespace. |
198
|
| '+' is not preceded with whitespace. |
198
|
| '+' is not preceded with whitespace. |
198
|
| '+' is not followed by whitespace. |
198
|
| Line is longer than 80 characters. |
203
|
| ',' is not followed by whitespace. |
203
|
| Line is longer than 80 characters. |
208
|
| 'cast' is not followed by whitespace. |
208
|
| Line is longer than 80 characters. |
213
|
| '}' should be on the same line. |
216
|
| Line is longer than 80 characters. |
218
|
| Line has trailing spaces. |
220
|
| Line has trailing spaces. |
231
|
| Expected an @return tag. |
235
|
| Method 'createFQANEvidenceFromGSS' is not designed for extension - needs to be abstract, final or empty. |
235
|
| Parameter gssContext should be final. |
235
|
| Expected @param tag for 'gssContext'. |
235
|
| Line has trailing spaces. |
241
|
| Line is longer than 80 characters. |
248
|
| Line has trailing spaces. |
249
|
| Expected an @return tag. |
253
|
| Line has trailing spaces. |
253
|
| Line is longer than 80 characters. |
253
|
| Method 'queryAuthZService' is not designed for extension - needs to be abstract, final or empty. |
253
|
| '(' is followed by whitespace. |
253
|
| Parameter samlSubject should be final. |
253
|
| Expected @param tag for 'samlSubject'. |
253
|
| Line is longer than 80 characters. |
254
|
| Line contains a tab character. |
254
|
| Parameter samlEvidence should be final. |
254
|
| Expected @param tag for 'samlEvidence'. |
254
|
| Line is longer than 80 characters. |
255
|
| Line contains a tab character. |
255
|
| Parameter samlActions should be final. |
255
|
| Expected @param tag for 'samlActions'. |
255
|
| Line is longer than 80 characters. |
256
|
| Line contains a tab character. |
256
|
| Parameter requestedServiceName should be final. |
256
|
| Expected @param tag for 'requestedServiceName'. |
256
|
| Line has trailing spaces. |
257
|
| Parameter contact should be final. |
257
|
| Expected @param tag for 'contact'. |
257
|
| Line is longer than 80 characters. |
258
|
| Expected @throws tag for 'SAMLException'. |
258
|
| Redundant throws: 'SAMLException' is subclass of 'java.lang.Exception'. |
258
|
| Expected @throws tag for 'javax.xml.rpc.ServiceException'. |
258
|
| Redundant throws: 'javax.xml.rpc.ServiceException' is subclass of 'java.lang.Exception'. |
258
|
| Expected @throws tag for 'java.rmi.RemoteException'. |
258
|
| Redundant throws: 'java.rmi.RemoteException' is subclass of 'java.lang.Exception'. |
258
|
| Expected @throws tag for 'java.lang.Exception'. |
258
|
| Line has trailing spaces. |
259
|
| Line has trailing spaces. |
266
|
| Line contains a tab character. |
266
|
| Line has trailing spaces. |
268
|
| Line has trailing spaces. |
269
|
| Line contains a tab character. |
270
|
| Line is longer than 80 characters. |
271
|
| Line contains a tab character. |
271
|
| Line contains a tab character. |
274
|
| Line is longer than 80 characters. |
275
|
| Line is longer than 80 characters. |
279
|
| '(' is followed by whitespace. |
279
|
| Line is longer than 80 characters. |
280
|
| '(' is followed by whitespace. |
280
|
| Line is longer than 80 characters. |
282
|
| Line contains a tab character. |
283
|
| Line contains a tab character. |
284
|
| Line contains a tab character. |
287
|
| Line contains a tab character. |
288
|
| 'cast' is not followed by whitespace. |
288
|
| Line contains a tab character. |
290
|
| Line has trailing spaces. |
291
|
| Line contains a tab character. |
291
|
| Line is longer than 80 characters. |
292
|
| Line has trailing spaces. |
293
|
| '+' is not preceded with whitespace. |
294
|
| '+' is not followed by whitespace. |
294
|
| '+' is not preceded with whitespace. |
294
|
| '+' is not followed by whitespace. |
294
|
| '+' is not preceded with whitespace. |
294
|
| '+' is not followed by whitespace. |
294
|
| Line has trailing spaces. |
297
|
| Line contains a tab character. |
297
|
| Line is longer than 80 characters. |
298
|
| Line contains a tab character. |
298
|
| Line is longer than 80 characters. |
300
|
| Line is longer than 80 characters. |
303
|
| Line is longer than 80 characters. |
304
|
| Line has trailing spaces. |
306
|
| Line has trailing spaces. |
307
|
| Line contains a tab character. |
307
|
| Line has trailing spaces. |
308
|
| Line has trailing spaces. |
309
|
| Line contains a tab character. |
309
|
| Line is longer than 80 characters. |
310
|
| Line contains a tab character. |
312
|
| Line contains a tab character. |
314
|
| Line is longer than 80 characters. |
315
|
| Line contains a tab character. |
315
|
| Line contains a tab character. |
319
|
| Line contains a tab character. |
323
|
| Line contains a tab character. |
324
|
| Line has trailing spaces. |
325
|
| Line contains a tab character. |
325
|
| '||' should be on a new line. |
325
|
| Line contains a tab character. |
326
|
| Line is longer than 80 characters. |
327
|
| Line contains a tab character. |
327
|
| Line contains a tab character. |
329
|
| '+' is not preceded with whitespace. |
331
|
| '+' is not followed by whitespace. |
331
|
| Line is longer than 80 characters. |
334
|
| Line contains a tab character. |
336
|
| Line has trailing spaces. |
337
|
| Line contains a tab character. |
337
|
| Line contains a tab character. |
339
|
| Line contains a tab character. |
340
|
| 'cast' is not followed by whitespace. |
341
|
| Line has trailing spaces. |
342
|
| Line contains a tab character. |
344
|
| Line contains a tab character. |
345
|
| Line contains a tab character. |
346
|
| Line has trailing spaces. |
347
|
| Line has trailing spaces. |
348
|
| Line contains a tab character. |
348
|
| Line has trailing spaces. |
350
|
| Line contains a tab character. |
350
|
| Line contains a tab character. |
351
|
| ')' is preceded with whitespace. |
351
|
| Line is longer than 80 characters. |
352
|
| Line contains a tab character. |
352
|
| Line has trailing spaces. |
354
|
| Line contains a tab character. |
354
|
| '}' should be on the same line. |
354
|
| Line has trailing spaces. |
356
|
| Line is longer than 80 characters. |
356
|
| Line contains a tab character. |
357
|
| Line contains a tab character. |
358
|
| '}' should be on the same line. |
358
|
| Line has trailing spaces. |
360
|
| Line contains a tab character. |
361
|
| Line has trailing spaces. |
362
|
| Line contains a tab character. |
363
|
| '}' should be on the same line. |
363
|
| Line has trailing spaces. |
369
|
| Line contains a tab character. |
369
|
| Line is longer than 80 characters. |
374
|
| Line has trailing spaces. |
380
|
| Line is longer than 80 characters. |
382
|
| Line has trailing spaces. |
383
|
| Line is longer than 80 characters. |
386
|
| Line is longer than 80 characters. |
387
|
| Line is longer than 80 characters. |
389
|
| Expected an @return tag. |
392
|
| Line has trailing spaces. |
392
|
| Line is longer than 80 characters. |
392
|
| Method 'processAuthzStmt' is not designed for extension - needs to be abstract, final or empty. |
392
|
| Method length is 164 lines (max allowed is 150). |
392
|
| Parameter stmt should be final. |
392
|
| Expected @param tag for 'stmt'. |
392
|
| Parameter resource should be final. |
392
|
| Expected @param tag for 'resource'. |
392
|
| Line is longer than 80 characters. |
393
|
| Line contains a tab character. |
393
|
| Parameter actions should be final. |
393
|
| Expected @param tag for 'actions'. |
393
|
| Parameter samlSubject should be final. |
393
|
| Expected @param tag for 'samlSubject'. |
393
|
| Line has trailing spaces. |
394
|
| Line contains a tab character. |
394
|
| Line is longer than 80 characters. |
396
|
| Line has trailing spaces. |
399
|
| Line contains a tab character. |
399
|
| Line contains a tab character. |
400
|
| '&&' should be on a new line. |
400
|
| Line contains a tab character. |
401
|
| Line contains a tab character. |
402
|
| Line has trailing spaces. |
403
|
| Line contains a tab character. |
403
|
| Line contains a tab character. |
405
|
| Line is longer than 80 characters. |
406
|
| Line contains a tab character. |
406
|
| Line has trailing spaces. |
407
|
| Line contains a tab character. |
410
|
| Line is longer than 80 characters. |
413
|
| '+' is not followed by whitespace. |
413
|
| '=' is not preceded with whitespace. |
415
|
| '=' is not followed by whitespace. |
415
|
| 'for' is not followed by whitespace. |
416
|
| '=' is not preceded with whitespace. |
416
|
| '=' is not followed by whitespace. |
416
|
| '<' is not preceded with whitespace. |
416
|
| '<' is not followed by whitespace. |
416
|
| 'for' is not followed by whitespace. |
420
|
| '=' is not preceded with whitespace. |
420
|
| '=' is not followed by whitespace. |
420
|
| ';' is not followed by whitespace. |
420
|
| '<' is not preceded with whitespace. |
420
|
| '<' is not followed by whitespace. |
420
|
| ';' is not followed by whitespace. |
420
|
| '{' is not preceded with whitespace. |
420
|
| 'if' is not followed by whitespace. |
421
|
| 'cast' is not followed by whitespace. |
421
|
| Line is longer than 80 characters. |
422
|
| 'cast' is not followed by whitespace. |
422
|
| 'if' construct must use '{}'s. |
427
|
| Line is longer than 80 characters. |
427
|
| 'if' is not followed by whitespace. |
427
|
| '!=' is not preceded with whitespace. |
427
|
| '!=' is not followed by whitespace. |
427
|
| Line has trailing spaces. |
429
|
| Line has trailing spaces. |
430
|
| 'if' is not followed by whitespace. |
430
|
| '==' is not preceded with whitespace. |
430
|
| '==' is not followed by whitespace. |
430
|
| Line is longer than 80 characters. |
432
|
| Line is longer than 80 characters. |
433
|
| Line is longer than 80 characters. |
436
|
| Line has trailing spaces. |
437
|
| Line has trailing spaces. |
439
|
| Line contains a tab character. |
439
|
| Line contains a tab character. |
440
|
| Line is longer than 80 characters. |
441
|
| '+' is not preceded with whitespace. |
441
|
| '+' is not followed by whitespace. |
441
|
| Line is longer than 80 characters. |
442
|
| '+' is not preceded with whitespace. |
442
|
| '+' is not followed by whitespace. |
442
|
| 'if' construct must use '{}'s. |
443
|
| Line is longer than 80 characters. |
443
|
| 'if' is not followed by whitespace. |
443
|
| 'else' construct must use '{}'s. |
445
|
| Line is longer than 80 characters. |
447
|
| '+' is not preceded with whitespace. |
447
|
| '+' is not followed by whitespace. |
447
|
| Line is longer than 80 characters. |
448
|
| '+' is not preceded with whitespace. |
448
|
| '+' is not followed by whitespace. |
448
|
| 'if' construct must use '{}'s. |
449
|
| Line is longer than 80 characters. |
449
|
| 'if' is not followed by whitespace. |
449
|
| 'else' construct must use '{}'s. |
451
|
| Line is longer than 80 characters. |
453
|
| '+' is not preceded with whitespace. |
453
|
| '+' is not followed by whitespace. |
453
|
| Line is longer than 80 characters. |
454
|
| '+' is not preceded with whitespace. |
454
|
| '+' is not followed by whitespace. |
454
|
| 'if' construct must use '{}'s. |
455
|
| Line is longer than 80 characters. |
455
|
| 'if' is not followed by whitespace. |
455
|
| 'else' construct must use '{}'s. |
457
|
| Line contains a tab character. |
460
|
| Line has trailing spaces. |
462
|
| 'if' is not followed by whitespace. |
463
|
| Line has trailing spaces. |
466
|
| 'if' is not followed by whitespace. |
469
|
| Line has trailing spaces. |
471
|
| Line is longer than 80 characters. |
472
|
| Line has trailing spaces. |
473
|
| Line has trailing spaces. |
476
|
| Line has trailing spaces. |
477
|
| Line is longer than 80 characters. |
477
|
| 'if' is not followed by whitespace. |
477
|
| ')' is preceded with whitespace. |
478
|
| Line has trailing spaces. |
479
|
| 'if' construct must use '{}'s. |
480
|
| Line has trailing spaces. |
480
|
| 'if' is not followed by whitespace. |
480
|
| '!=' is not followed by whitespace. |
480
|
| Line is longer than 80 characters. |
481
|
| Line is longer than 80 characters. |
482
|
| 'if' is not followed by whitespace. |
482
|
| Line is longer than 80 characters. |
483
|
| ')' is preceded with whitespace. |
483
|
| Line has trailing spaces. |
486
|
| Line is longer than 80 characters. |
486
|
| Line has trailing spaces. |
489
|
| '}' should be on the same line. |
489
|
| Line has trailing spaces. |
490
|
| Line is longer than 80 characters. |
490
|
| 'if' is not followed by whitespace. |
490
|
| ')' is preceded with whitespace. |
491
|
| Line has trailing spaces. |
492
|
| 'if' construct must use '{}'s. |
493
|
| Line has trailing spaces. |
493
|
| 'if' is not followed by whitespace. |
493
|
| '!=' is not followed by whitespace. |
493
|
| Line is longer than 80 characters. |
494
|
| Line is longer than 80 characters. |
495
|
| 'if' is not followed by whitespace. |
495
|
| Line is longer than 80 characters. |
496
|
| ')' is preceded with whitespace. |
496
|
| Line has trailing spaces. |
499
|
| Line is longer than 80 characters. |
499
|
| Line has trailing spaces. |
502
|
| '}' should be on the same line. |
502
|
| Line has trailing spaces. |
503
|
| Line is longer than 80 characters. |
503
|
| 'if' is not followed by whitespace. |
503
|
| ')' is preceded with whitespace. |
504
|
| Line has trailing spaces. |
505
|
| Line is longer than 80 characters. |
505
|
| 'if' construct must use '{}'s. |
506
|
| Line has trailing spaces. |
506
|
| 'if' is not followed by whitespace. |
506
|
| '!=' is not followed by whitespace. |
506
|
| Line is longer than 80 characters. |
507
|
| Line is longer than 80 characters. |
508
|
| 'if' is not followed by whitespace. |
508
|
| Line is longer than 80 characters. |
509
|
| ')' is preceded with whitespace. |
509
|
| Line is longer than 80 characters. |
510
|
| Line is longer than 80 characters. |
511
|
| Line has trailing spaces. |
513
|
| Line is longer than 80 characters. |
513
|
| Line has trailing spaces. |
516
|
| '}' should be on the same line. |
516
|
| Line has trailing spaces. |
517
|
| Line is longer than 80 characters. |
517
|
| 'if' is not followed by whitespace. |
517
|
| ')' is preceded with whitespace. |
518
|
| Line has trailing spaces. |
519
|
| 'if' construct must use '{}'s. |
520
|
| Line has trailing spaces. |
520
|
| 'if' is not followed by whitespace. |
520
|
| '!=' is not followed by whitespace. |
520
|
| Line is longer than 80 characters. |
521
|
| Line is longer than 80 characters. |
522
|
| 'if' is not followed by whitespace. |
522
|
| Line is longer than 80 characters. |
523
|
| ')' is preceded with whitespace. |
523
|
| Line has trailing spaces. |
526
|
| Line is longer than 80 characters. |
526
|
| Line has trailing spaces. |
529
|
| '}' should be on the same line. |
529
|
| Line has trailing spaces. |
530
|
| Line is longer than 80 characters. |
530
|
| Line contains a tab character. |
530
|
| 'if' is not followed by whitespace. |
530
|
| ')' is preceded with whitespace. |
531
|
| Line has trailing spaces. |
532
|
| Line is longer than 80 characters. |
532
|
| 'if' construct must use '{}'s. |
533
|
| Line has trailing spaces. |
533
|
| 'if' is not followed by whitespace. |
533
|
| '!=' is not followed by whitespace. |
533
|
| Line is longer than 80 characters. |
534
|
| Line is longer than 80 characters. |
535
|
| 'if' is not followed by whitespace. |
535
|
| Line is longer than 80 characters. |
536
|
| ')' is preceded with whitespace. |
536
|
| Line has trailing spaces. |
539
|
| Line is longer than 80 characters. |
539
|
| Line has trailing spaces. |
542
|
| '}' should be on the same line. |
542
|
| Line has trailing spaces. |
547
|
| Line has trailing spaces. |
548
|
| Line has trailing spaces. |
549
|
| Method 'getGlobusCredentials' is not designed for extension - needs to be abstract, final or empty. |
567
|
| Line is longer than 80 characters. |
575
|
| Method 'setGlobusCredentials' is not designed for extension - needs to be abstract, final or empty. |
575
|
| Parameter globusCredentials should be final. |
575
|
| 'globusCredentials' hides a field. |
575
|
org/opensciencegrid/authz/client/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/opensciencegrid/authz/common/GridId.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Line is longer than 80 characters. |
25
|
| Method 'getHostDN' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Line is longer than 80 characters. |
34
|
| Unused @param tag for 'host'. |
34
|
| Method 'setHostDN' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Parameter hostDN should be final. |
36
|
| 'hostDN' hides a field. |
36
|
| Expected @param tag for 'hostDN'. |
36
|
| Line is longer than 80 characters. |
43
|
| Method 'getUserDN' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Line is longer than 80 characters. |
52
|
| Method 'setUserDN' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter userDN should be final. |
54
|
| 'userDN' hides a field. |
54
|
| Line is longer than 80 characters. |
60
|
| Method 'getUserFQAN' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Line is longer than 80 characters. |
69
|
| Method 'setUserFQAN' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Parameter userFQAN should be final. |
72
|
| 'userFQAN' hides a field. |
72
|
| Method 'getUserFQANIssuer' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Method 'setUserFQANIssuer' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Parameter userFQANIssuer should be final. |
90
|
| 'userFQANIssuer' hides a field. |
90
|
| First sentence should end with a period. |
96
|
| Line has trailing spaces. |
96
|
| Expected an @return tag. |
99
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
99
|
| '+' is not preceded with whitespace. |
100
|
| '+' is not followed by whitespace. |
100
|
| '+' is not followed by whitespace. |
101
|
| '+' is not preceded with whitespace. |
101
|
| '+' is not followed by whitespace. |
101
|
| '+' is not followed by whitespace. |
102
|
| '+' is not preceded with whitespace. |
102
|
| '+' is not followed by whitespace. |
102
|
| '+' is not followed by whitespace. |
103
|
| '+' is not preceded with whitespace. |
103
|
| '+' is not followed by whitespace. |
103
|
| Line has trailing spaces. |
105
|
| Line has trailing spaces. |
106
|
org/opensciencegrid/authz/common/LocalId.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
22
|
| Line is longer than 80 characters. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter userName should be final. |
25
|
| 'userName' hides a field. |
25
|
| Parameter groupName should be final. |
25
|
| 'groupName' hides a field. |
25
|
| Parameter supplementalGroupNames should be final. |
25
|
| 'supplementalGroupNames' hides a field. |
25
|
| Parameter rootPath should be final. |
26
|
| 'rootPath' hides a field. |
26
|
| Parameter relHomePath should be final. |
26
|
| 'relHomePath' hides a field. |
26
|
| 'if' is not followed by whitespace. |
30
|
| 'for' construct must use '{}'s. |
32
|
| 'for' is not followed by whitespace. |
32
|
| '=' is not preceded with whitespace. |
32
|
| '=' is not followed by whitespace. |
32
|
| Method 'getUserName' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Unused @param tag for 'username'. |
54
|
| Method 'setUserName' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter userName should be final. |
56
|
| 'userName' hides a field. |
56
|
| Expected @param tag for 'userName'. |
56
|
| Method 'getGroupName' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Unused @param tag for 'group'. |
72
|
| Method 'setGroupName' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Parameter g should be final. |
75
|
| Expected @param tag for 'g'. |
75
|
| Method 'getSupplementalGroupNames' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Unused @param tag for 'supplementalGroups'. |
91
|
| Method 'setSupplementalGroupNames' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Parameter sg should be final. |
93
|
| Expected @param tag for 'sg'. |
93
|
| 'for' construct must use '{}'s. |
95
|
| 'for' is not followed by whitespace. |
95
|
| '=' is not preceded with whitespace. |
95
|
| '=' is not followed by whitespace. |
95
|
| Line has trailing spaces. |
97
|
| Method 'getRootPath' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Method 'setRootPath' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Parameter rootPath should be final. |
113
|
| 'rootPath' hides a field. |
113
|
| Method 'getRelativeHomePath' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Method 'setRelativeHomePath' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Parameter relHomePath should be final. |
131
|
| 'relHomePath' hides a field. |
131
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Missing a Javadoc comment. |
136
|
| 'if' construct must use '{}'s. |
143
|
| '8' is a magic number. |
143
|
| 'if' construct must use '{}'s. |
148
|
| '8' is a magic number. |
148
|
| 'if' construct must use '{}'s. |
153
|
| '8' is a magic number. |
153
|
| Line has trailing spaces. |
160
|
| Line has trailing spaces. |
161
|
org/opensciencegrid/authz/common/OSGAuthorizationConstants.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
8
|
| Missing a Javadoc comment. |
16
|
| Line has trailing spaces. |
19
|
| Missing a Javadoc comment. |
20
|
| 'public' modifier out of order with the JLS suggestions. |
20
|
| Missing a Javadoc comment. |
24
|
| 'public' modifier out of order with the JLS suggestions. |
24
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
29
|
| Missing a Javadoc comment. |
29
|
| 'public' modifier out of order with the JLS suggestions. |
29
|
| Line is longer than 80 characters. |
30
|
| Missing a Javadoc comment. |
30
|
| 'public' modifier out of order with the JLS suggestions. |
30
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
32
|
| Missing a Javadoc comment. |
32
|
| 'public' modifier out of order with the JLS suggestions. |
32
|
| Line is longer than 80 characters. |
33
|
| Missing a Javadoc comment. |
33
|
| 'public' modifier out of order with the JLS suggestions. |
33
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
36
|
| 'public' modifier out of order with the JLS suggestions. |
36
|
| Line is longer than 80 characters. |
37
|
| Missing a Javadoc comment. |
37
|
| 'public' modifier out of order with the JLS suggestions. |
37
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
39
|
| Missing a Javadoc comment. |
39
|
| 'public' modifier out of order with the JLS suggestions. |
39
|
| Line is longer than 80 characters. |
40
|
| Missing a Javadoc comment. |
40
|
| 'public' modifier out of order with the JLS suggestions. |
40
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
42
|
| Missing a Javadoc comment. |
42
|
| 'public' modifier out of order with the JLS suggestions. |
42
|
| Line is longer than 80 characters. |
43
|
| Missing a Javadoc comment. |
43
|
| 'public' modifier out of order with the JLS suggestions. |
43
|
| Line is longer than 80 characters. |
45
|
| Missing a Javadoc comment. |
45
|
| 'public' modifier out of order with the JLS suggestions. |
45
|
| Line has trailing spaces. |
50
|
| Line has trailing spaces. |
51
|
| Missing a Javadoc comment. |
51
|
| Name 'AUTHZDECISIONSTATEMENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
51
|
| Variable 'AUTHZDECISIONSTATEMENT' must be private and have accessor methods. |
51
|
| Line is longer than 80 characters. |
52
|
| ',' is not followed by whitespace. |
52
|
| Line has trailing spaces. |
54
|
| Missing a Javadoc comment. |
54
|
| Name 'OBLIGATEDAUTHZDECISIONSTATEMENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
| Variable 'OBLIGATEDAUTHZDECISIONSTATEMENT' must be private and have accessor methods. |
54
|
| Line is longer than 80 characters. |
55
|
| ',' is not followed by whitespace. |
55
|
org/opensciencegrid/authz/common/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/opensciencegrid/authz/saml/OSGXML.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
5
|
| '{' should be on the previous line. |
12
|
| First sentence should end with a period. |
14
|
| Line is longer than 80 characters. |
15
|
| 'static' modifier out of order with the JLS suggestions. |
15
|
org/opensciencegrid/authz/saml/ObligatedAuthorizationDecisionStatement.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - org.w3c.dom.*. |
119
|
| Using the '.*' form of import should be avoided - org.opensaml.v1_0_1.*. |
123
|
| Line is longer than 80 characters. |
149
|
| Line is longer than 80 characters. |
151
|
| First sentence should end with a period. |
155
|
| Line is longer than 80 characters. |
155
|
| Line is longer than 80 characters. |
161
|
| Missing a Javadoc comment. |
161
|
| Variable 'log' must be private and have accessor methods. |
161
|
| First sentence should end with a period. |
167
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
183
|
| Parameter subject should be final. |
193
|
| Parameter resource should be final. |
195
|
| Parameter decision should be final. |
195
|
| Expected @param tag for 'decision'. |
195
|
| Parameter actions should be final. |
197
|
| Parameter evidence should be final. |
199
|
| Parameter xacmlObligations should be final. |
201
|
| 'xacmlObligations' hides a field. |
201
|
| Line has trailing spaces. |
205
|
| Line is longer than 80 characters. |
217
|
| Line is longer than 80 characters. |
225
|
| First sentence should end with a period. |
231
|
| Parameter e should be final. |
243
|
| '{' should be on the previous line. |
247
|
| Line is longer than 80 characters. |
251
|
| First sentence should end with a period. |
261
|
| Line is longer than 80 characters. |
269
|
| Parameter in should be final. |
275
|
| '{' should be on the previous line. |
279
|
| Line is longer than 80 characters. |
283
|
| Line is longer than 80 characters. |
309
|
| Method 'fromDOM' is not designed for extension - needs to be abstract, final or empty. |
315
|
| Parameter e should be final. |
315
|
| '{' should be on the previous line. |
319
|
| Line has trailing spaces. |
327
|
| '&&' should be on a new line. |
327
|
| Line is longer than 80 characters. |
329
|
| ',' is not followed by whitespace. |
329
|
| ',' is not followed by whitespace. |
329
|
| '{' should be on the previous line. |
331
|
| 'if' construct must use '{}'s. |
335
|
| Line is longer than 80 characters. |
335
|
| ',' is not followed by whitespace. |
335
|
| ',' is not followed by whitespace. |
335
|
| ',' is not followed by whitespace. |
335
|
| ',' is not followed by whitespace. |
335
|
| '||' should be on a new line. |
335
|
| Line is longer than 80 characters. |
337
|
| Line is longer than 80 characters. |
339
|
| '+' is not preceded with whitespace. |
339
|
| '+' is not followed by whitespace. |
339
|
| '+' is not preceded with whitespace. |
339
|
| '+' is not followed by whitespace. |
339
|
| '{' should be on the previous line. |
353
|
| Line is longer than 80 characters. |
355
|
| 'cast' is not followed by whitespace. |
355
|
| Line is longer than 80 characters. |
357
|
| 'if' is not followed by whitespace. |
359
|
| '(' is followed by whitespace. |
365
|
| 'cast' is not followed by whitespace. |
365
|
| First sentence should end with a period. |
379
|
| Method 'getXACMLObligations' is not designed for extension - needs to be abstract, final or empty. |
389
|
| 'if' construct must use '{}'s. |
393
|
| Line has trailing spaces. |
393
|
| 'if' is not followed by whitespace. |
393
|
| '==' is not preceded with whitespace. |
393
|
| '==' is not followed by whitespace. |
393
|
| 'else' construct must use '{}'s. |
397
|
| Line has trailing spaces. |
409
|
| Line has trailing spaces. |
419
|
| Line has trailing spaces. |
423
|
| Line is longer than 80 characters. |
423
|
| Line has trailing spaces. |
425
|
| Line is longer than 80 characters. |
425
|
| Line is longer than 80 characters. |
429
|
| Unclosed HTML tag found: <saml:Statement xsi:type="osg-saml:ObligatedAuthorizationDec |
429
|
| Line contains a tab character. |
429
|
| Method 'toDOM' is not designed for extension - needs to be abstract, final or empty. |
441
|
| Parameter doc should be final. |
441
|
| Parameter xmlns should be final. |
441
|
| Expected @throws tag for 'SAMLException'. |
441
|
| Line is longer than 80 characters. |
445
|
| Line is longer than 80 characters. |
449
|
| Line is longer than 80 characters. |
457
|
| Line is longer than 80 characters. |
459
|
| Line has trailing spaces. |
473
|
| 'while' construct must use '{}'s. |
477
|
| 'cast' is not followed by whitespace. |
479
|
| Line has trailing spaces. |
481
|
| 'if' construct must use '{}'s. |
489
|
| 'cast' is not followed by whitespace. |
491
|
| 'if' construct must use '{}'s. |
493
|
| Line is longer than 80 characters. |
495
|
| ',' is not followed by whitespace. |
495
|
| 'cast' is not followed by whitespace. |
495
|
| 'while' construct must use '{}'s. |
505
|
| 'cast' is not followed by whitespace. |
507
|
| Line has trailing spaces. |
509
|
org/opensciencegrid/authz/saml/SAMLExtensionInit.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
13
|
| Utility classes should not have a public or default constructor. |
35
|
| '{' should be on the previous line. |
37
|
| Missing a Javadoc comment. |
39
|
| First sentence should end with a period. |
43
|
| Line has trailing spaces. |
45
|
| '{' should be on the previous line. |
55
|
| 'if' construct must use '{}'s. |
57
|
| Line is longer than 80 characters. |
63
|
| Line has trailing spaces. |
65
|
| Line is longer than 80 characters. |
65
|
| Line has trailing spaces. |
67
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
69
|
org/opensciencegrid/authz/saml/SAMLUtil.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
13
|
| Utility classes should not have a public or default constructor. |
33
|
| '{' should be on the previous line. |
35
|
| First sentence should end with a period. |
39
|
| Expected an @return tag. |
49
|
| Parameter s1 should be final. |
49
|
| Expected @param tag for 's1'. |
49
|
| Parameter s2 should be final. |
49
|
| Expected @param tag for 's2'. |
49
|
| 'if' construct must use '{}'s. |
53
|
| 'if' is not followed by whitespace. |
53
|
| 'if' construct must use '{}'s. |
55
|
| Line is longer than 80 characters. |
55
|
| 'if' is not followed by whitespace. |
55
|
| 'if' construct must use '{}'s. |
57
|
| 'if' is not followed by whitespace. |
57
|
| Line has trailing spaces. |
71
|
| Line has trailing spaces. |
75
|
| Expected an @return tag. |
83
|
| Parameter s1 should be final. |
83
|
| Expected @param tag for 's1'. |
83
|
| Parameter s2 should be final. |
83
|
| Expected @param tag for 's2'. |
83
|
| 'if' construct must use '{}'s. |
87
|
| 'if' is not followed by whitespace. |
87
|
| 'if' construct must use '{}'s. |
89
|
| 'if' is not followed by whitespace. |
89
|
org/opensciencegrid/authz/saml/XACMLObligation.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.io.IOException. |
103
|
| Unused import - java.lang.reflect.Constructor. |
107
|
| Unused import - java.util.Collection. |
109
|
| Unused import - java.util.Hashtable. |
111
|
| Unused import - java.util.Iterator. |
113
|
| Unused import - java.util.ArrayList. |
115
|
| Unused import - org.apache.log4j.NDC. |
121
|
| Using the '.*' form of import should be avoided - org.w3c.dom.*. |
123
|
| Using the '.*' form of import should be avoided - org.opensaml.v1_0_1.*. |
127
|
| Line has trailing spaces. |
135
|
| Line has trailing spaces. |
139
|
| '{' should be on the previous line. |
161
|
| First sentence should end with a period. |
165
|
| Variable 'obligationId' must be private and have accessor methods. |
167
|
| First sentence should end with a period. |
171
|
| Variable 'fullfillOn' must be private and have accessor methods. |
173
|
| First sentence should end with a period. |
177
|
| Variable 'attributeId' must be private and have accessor methods. |
179
|
| First sentence should end with a period. |
183
|
| Variable 'datatype' must be private and have accessor methods. |
185
|
| First sentence should end with a period. |
189
|
| Variable 'value' must be private and have accessor methods. |
191
|
| First sentence should end with a period. |
195
|
| Variable 'log' must be private and have accessor methods. |
197
|
| First sentence should end with a period. |
201
|
| Unused @param tag for 'dataype'. |
213
|
| Line is longer than 80 characters. |
225
|
| Parameter obligationId should be final. |
225
|
| 'obligationId' hides a field. |
225
|
| Parameter fullfillOn should be final. |
225
|
| 'fullfillOn' hides a field. |
225
|
| Parameter attributeId should be final. |
225
|
| 'attributeId' hides a field. |
225
|
| Parameter datatype should be final. |
225
|
| 'datatype' hides a field. |
225
|
| Expected @param tag for 'datatype'. |
225
|
| Parameter value should be final. |
225
|
| 'value' hides a field. |
225
|
| '{' should be on the previous line. |
229
|
| 'if' construct must use '{}'s. |
231
|
| ')' is preceded with whitespace. |
231
|
| Line is longer than 80 characters. |
233
|
| 'if' construct must use '{}'s. |
235
|
| '==' is not followed by whitespace. |
235
|
| ')' is preceded with whitespace. |
235
|
| Line is longer than 80 characters. |
237
|
| 'if' construct must use '{}'s. |
239
|
| Line is longer than 80 characters. |
239
|
| Line is longer than 80 characters. |
241
|
| Line has trailing spaces. |
261
|
| First sentence should end with a period. |
263
|
| First sentence should end with a period. |
275
|
| Parameter e should be final. |
289
|
| '{' should be on the previous line. |
293
|
| First sentence should end with a period. |
303
|
| Line is longer than 80 characters. |
311
|
| Parameter in should be final. |
317
|
| '{' should be on the previous line. |
321
|
| Line is longer than 80 characters. |
339
|
| Method 'fromDOM' is not designed for extension - needs to be abstract, final or empty. |
345
|
| Parameter e should be final. |
345
|
| '{' should be on the previous line. |
349
|
| '&&' should be on a new line. |
357
|
| ',' is not followed by whitespace. |
359
|
| ',' is not followed by whitespace. |
359
|
| '{' should be on the previous line. |
361
|
| Line is longer than 80 characters. |
363
|
| Line is longer than 80 characters. |
365
|
| '+' is not followed by whitespace. |
365
|
| '+' is not preceded with whitespace. |
365
|
| '+' is not followed by whitespace. |
365
|
| Line is longer than 80 characters. |
381
|
| '{' should be on the previous line. |
387
|
| '{' should be on the previous line. |
391
|
| Line is longer than 80 characters. |
393
|
| Line is longer than 80 characters. |
397
|
| Line is longer than 80 characters. |
401
|
| Line is longer than 80 characters. |
407
|
| Line has trailing spaces. |
411
|
| Line is longer than 80 characters. |
415
|
| '+' is not preceded with whitespace. |
415
|
| '+' is not preceded with whitespace. |
417
|
| '+' is not followed by whitespace. |
417
|
| '+' is not preceded with whitespace. |
417
|
| '+' is not preceded with whitespace. |
419
|
| '+' is not followed by whitespace. |
419
|
| First sentence should end with a period. |
427
|
| Method 'toDOM' is not designed for extension - needs to be abstract, final or empty. |
439
|
| Parameter doc should be final. |
439
|
| Expected @throws tag for 'SAMLException'. |
439
|
| '{' should be on the previous line. |
441
|
| 'if' construct must use '{}'s. |
443
|
| Line is longer than 80 characters. |
449
|
| ',' is not followed by whitespace. |
449
|
| Line is longer than 80 characters. |
451
|
| Line contains a tab character. |
453
|
| ',' is not followed by whitespace. |
453
|
| ',' is not followed by whitespace. |
455
|
| Line is longer than 80 characters. |
459
|
| ',' is not followed by whitespace. |
459
|
| Line is longer than 80 characters. |
461
|
| ',' is not followed by whitespace. |
463
|
| ',' is not followed by whitespace. |
465
|
| First sentence should end with a period. |
483
|
| Line is longer than 80 characters. |
485
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
497
|
| Expected @throws tag for 'CloneNotSupportedException'. |
499
|
| '{' should be on the previous line. |
501
|
| Line is longer than 80 characters. |
505
|
| '=' is not preceded with whitespace. |
505
|
| '=' is not followed by whitespace. |
505
|
| '}' should be on the same line. |
509
|
| Method 'getObligationId' is not designed for extension - needs to be abstract, final or empty. |
523
|
| Missing a Javadoc comment. |
523
|
| Method 'getFullfillOn' is not designed for extension - needs to be abstract, final or empty. |
531
|
| Missing a Javadoc comment. |
531
|
| Method 'getAttributeId' is not designed for extension - needs to be abstract, final or empty. |
539
|
| Missing a Javadoc comment. |
539
|
| Method 'getDatatype' is not designed for extension - needs to be abstract, final or empty. |
547
|
| Missing a Javadoc comment. |
547
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
555
|
| Missing a Javadoc comment. |
555
|
org/opensciencegrid/authz/saml/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/opensciencegrid/authz/service/BasicMappingAuthZService.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
34
|
| First sentence should end with a period. |
37
|
| Variable 'mapService' must be private and have accessor methods. |
38
|
| First sentence should end with a period. |
40
|
| Line is longer than 80 characters. |
41
|
| Variable 'serviceIdentity' must be private and have accessor methods. |
41
|
| Line has trailing spaces. |
42
|
| First sentence should end with a period. |
43
|
| Line is longer than 80 characters. |
44
|
| Variable 'log' must be private and have accessor methods. |
44
|
| ')' is preceded with whitespace. |
44
|
| Line is longer than 80 characters. |
46
|
| Parameter mapService should be final. |
50
|
| 'mapService' hides a field. |
50
|
| Expected @param tag for 'mapService'. |
50
|
| Line is longer than 80 characters. |
55
|
| First sentence should end with a period. |
61
|
| Line has trailing spaces. |
61
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
69
|
| Line has trailing spaces. |
71
|
| Line is longer than 80 characters. |
71
|
| Line has trailing spaces. |
72
|
| Expected an @return tag. |
75
|
| Line has trailing spaces. |
75
|
| Line is longer than 80 characters. |
75
|
| Method 'authorize' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Parameter subject should be final. |
75
|
| Expected @param tag for 'subject'. |
75
|
| Parameter resource should be final. |
75
|
| Expected @param tag for 'resource'. |
75
|
| Parameter actions should be final. |
75
|
| Expected @param tag for 'actions'. |
75
|
| Parameter evidence should be final. |
75
|
| Expected @param tag for 'evidence'. |
75
|
| Expected @throws tag for 'SAMLException'. |
76
|
| '=' is not preceded with whitespace. |
83
|
| '=' is not followed by whitespace. |
83
|
| Line has trailing spaces. |
87
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
88
|
| ')' is preceded with whitespace. |
88
|
| Line is longer than 80 characters. |
89
|
| '+' is not preceded with whitespace. |
89
|
| '+' is not followed by whitespace. |
89
|
| Line has trailing spaces. |
92
|
| Line is longer than 80 characters. |
92
|
| 'if' is not followed by whitespace. |
92
|
| '=' is not preceded with whitespace. |
92
|
| '=' is not followed by whitespace. |
92
|
| '!=' is not preceded with whitespace. |
92
|
| '!=' is not followed by whitespace. |
92
|
| Line has trailing spaces. |
93
|
| Line is longer than 80 characters. |
94
|
| Line has trailing spaces. |
96
|
| Line is longer than 80 characters. |
98
|
| 'if' construct must use '{}'s. |
100
|
| Line is longer than 80 characters. |
100
|
| 'if' is not followed by whitespace. |
100
|
| '!=' is not preceded with whitespace. |
100
|
| '!=' is not followed by whitespace. |
100
|
| '+' is not preceded with whitespace. |
100
|
| '+' is not followed by whitespace. |
100
|
| '+' is not preceded with whitespace. |
100
|
| '+' is not followed by whitespace. |
100
|
| '+' is not preceded with whitespace. |
100
|
| '+' is not followed by whitespace. |
100
|
| '+' is not preceded with whitespace. |
100
|
| '+' is not followed by whitespace. |
100
|
| 'else' construct must use '{}'s. |
101
|
| Line has trailing spaces. |
102
|
| 'if' is not followed by whitespace. |
107
|
| '!=' is not preceded with whitespace. |
107
|
| '!=' is not followed by whitespace. |
107
|
| Line has trailing spaces. |
115
|
| Line has trailing spaces. |
117
|
| 'if' is not followed by whitespace. |
117
|
| '!=' is not preceded with whitespace. |
117
|
| '!=' is not followed by whitespace. |
117
|
| Line has trailing spaces. |
120
|
| '}' should be on the same line. |
124
|
| Line has trailing spaces. |
131
|
| '}' should be on the same line. |
131
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
134
|
| Line has trailing spaces. |
135
|
| Line is longer than 80 characters. |
138
|
| Line is longer than 80 characters. |
139
|
| ')' is preceded with whitespace. |
139
|
| '=' is not preceded with whitespace. |
140
|
| '=' is not followed by whitespace. |
140
|
| First sentence should end with a period. |
149
|
| Line has trailing spaces. |
149
|
| Line has trailing spaces. |
150
|
| Expected an @return tag. |
152
|
| Line has trailing spaces. |
152
|
| Parameter localID should be final. |
152
|
| Expected @param tag for 'localID'. |
152
|
| Expected @throws tag for 'SAMLException'. |
153
|
| Line has trailing spaces. |
154
|
| 'if' construct must use '{}'s. |
159
|
| 'if' is not followed by whitespace. |
159
|
| '=' is not preceded with whitespace. |
159
|
| '=' is not followed by whitespace. |
159
|
| '!=' is not preceded with whitespace. |
159
|
| '!=' is not followed by whitespace. |
159
|
| Line is longer than 80 characters. |
160
|
| Line contains a tab character. |
161
|
| Line is longer than 80 characters. |
162
|
| Line is longer than 80 characters. |
163
|
| 'if' construct must use '{}'s. |
166
|
| 'if' is not followed by whitespace. |
166
|
| '=' is not preceded with whitespace. |
166
|
| '=' is not followed by whitespace. |
166
|
| '!=' is not preceded with whitespace. |
166
|
| '!=' is not followed by whitespace. |
166
|
| Line is longer than 80 characters. |
167
|
| Line contains a tab character. |
168
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
170
|
| 'if' is not followed by whitespace. |
174
|
| '=' is not preceded with whitespace. |
174
|
| '=' is not followed by whitespace. |
174
|
| '!=' is not preceded with whitespace. |
174
|
| '!=' is not followed by whitespace. |
174
|
| 'for' construct must use '{}'s. |
177
|
| Line has trailing spaces. |
177
|
| 'for' is not followed by whitespace. |
177
|
| '=' is not preceded with whitespace. |
177
|
| '=' is not followed by whitespace. |
177
|
| '<' is not preceded with whitespace. |
177
|
| '<' is not followed by whitespace. |
177
|
| '+' is not preceded with whitespace. |
178
|
| '+' is not followed by whitespace. |
178
|
| Line is longer than 80 characters. |
179
|
| Line contains a tab character. |
180
|
| Line is longer than 80 characters. |
181
|
| Line is longer than 80 characters. |
182
|
| 'if' construct must use '{}'s. |
186
|
| 'if' is not followed by whitespace. |
186
|
| '=' is not preceded with whitespace. |
186
|
| '=' is not followed by whitespace. |
186
|
| '!=' is not preceded with whitespace. |
186
|
| '!=' is not followed by whitespace. |
186
|
| Line is longer than 80 characters. |
187
|
| Line contains a tab character. |
188
|
| Line is longer than 80 characters. |
189
|
| Line is longer than 80 characters. |
190
|
| 'if' construct must use '{}'s. |
194
|
| 'if' is not followed by whitespace. |
194
|
| '=' is not preceded with whitespace. |
194
|
| '=' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '!=' is not followed by whitespace. |
194
|
| Line is longer than 80 characters. |
195
|
| Line contains a tab character. |
196
|
| Line is longer than 80 characters. |
197
|
| Line is longer than 80 characters. |
198
|
| Line has trailing spaces. |
201
|
| 'if' construct must use '{}'s. |
202
|
org/opensciencegrid/authz/service/GRIDIdentityMappingService.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
30
|
| Unused @throws tag for 'RuntimeException'. |
30
|
org/opensciencegrid/authz/service/GRIDIdentityMappingServiceExample.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
15
|
| Line has trailing spaces. |
16
|
| First sentence should end with a period. |
17
|
| Line is longer than 80 characters. |
19
|
| Line has trailing spaces. |
21
|
org/opensciencegrid/authz/service/GRIDIdentityMappingServiceExampleImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.util.StringTokenizer. |
9
|
| First sentence should end with a period. |
23
|
| Line has trailing spaces. |
24
|
| Line is longer than 80 characters. |
33
|
| First sentence should end with a period. |
35
|
| Line is longer than 80 characters. |
36
|
| Variable 'log' must be private and have accessor methods. |
36
|
| ')' is preceded with whitespace. |
36
|
| First sentence should end with a period. |
38
|
| Name 'STDMAPFILE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
39
|
| First sentence should end with a period. |
41
|
| First sentence should end with a period. |
44
|
| First sentence should end with a period. |
47
|
| Missing a Javadoc comment. |
49
|
| Variable 'subjectDN' must be private and have accessor methods. |
49
|
| Missing a Javadoc comment. |
50
|
| Variable 'fqan' must be private and have accessor methods. |
50
|
| Missing a Javadoc comment. |
51
|
| Parameter s should be final. |
51
|
| '{' is not followed by whitespace. |
51
|
| ';' is not followed by whitespace. |
51
|
| '}' is not preceded with whitespace. |
51
|
| Missing a Javadoc comment. |
52
|
| 'return' is not preceded with whitespace. |
52
|
| '{' is not followed by whitespace. |
52
|
| ';' is not followed by whitespace. |
52
|
| '}' is not preceded with whitespace. |
52
|
| Missing a Javadoc comment. |
53
|
| Parameter f should be final. |
53
|
| '{' is not followed by whitespace. |
53
|
| ';' is not followed by whitespace. |
53
|
| '}' is not preceded with whitespace. |
53
|
| Missing a Javadoc comment. |
54
|
| 'return' is not preceded with whitespace. |
54
|
| '{' is not followed by whitespace. |
54
|
| ';' is not followed by whitespace. |
54
|
| '}' is not preceded with whitespace. |
54
|
| Missing a Javadoc comment. |
55
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| '+' is not preceded with whitespace. |
56
|
| '+' is not followed by whitespace. |
56
|
| 'if' is not followed by whitespace. |
58
|
| '!=' is not preceded with whitespace. |
58
|
| '!=' is not followed by whitespace. |
58
|
| 'for' construct must use '{}'s. |
59
|
| Line has trailing spaces. |
59
|
| 'for' is not followed by whitespace. |
59
|
| '=' is not preceded with whitespace. |
59
|
| '=' is not followed by whitespace. |
59
|
| ';' is not followed by whitespace. |
59
|
| '<' is not preceded with whitespace. |
59
|
| '<' is not followed by whitespace. |
59
|
| ';' is not followed by whitespace. |
59
|
| '+' is not preceded with whitespace. |
60
|
| '+' is not followed by whitespace. |
60
|
| First sentence should end with a period. |
66
|
| Line has trailing spaces. |
66
|
| Line has trailing spaces. |
67
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
69
|
| 'if' construct must use '{}'s. |
71
|
| Line has trailing spaces. |
71
|
| 'if' is not followed by whitespace. |
71
|
| '!=' is not preceded with whitespace. |
71
|
| '!=' is not followed by whitespace. |
71
|
| '+' is not preceded with whitespace. |
72
|
| '+' is not followed by whitespace. |
72
|
| '=' is not preceded with whitespace. |
74
|
| '=' is not followed by whitespace. |
74
|
| '+' is not preceded with whitespace. |
76
|
| '+' is not followed by whitespace. |
76
|
| '+' is not preceded with whitespace. |
81
|
| '+' is not followed by whitespace. |
81
|
| 'if' construct must use '{}'s. |
84
|
| Line is longer than 80 characters. |
84
|
| 'if' is not followed by whitespace. |
84
|
| '==' is not preceded with whitespace. |
84
|
| '==' is not followed by whitespace. |
84
|
| 'else' construct must use '{}'s. |
85
|
| '+' is not preceded with whitespace. |
85
|
| '+' is not followed by whitespace. |
85
|
| First sentence should end with a period. |
88
|
| Line has trailing spaces. |
90
|
| Expected an @return tag. |
94
|
| Method 'mapCredentials' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Parameter gridID should be final. |
94
|
| Expected @param tag for 'gridID'. |
94
|
| 'if' construct must use '{}'s. |
98
|
| 'if' is not followed by whitespace. |
98
|
| '==' is not preceded with whitespace. |
98
|
| '==' is not followed by whitespace. |
98
|
| 'if' is not followed by whitespace. |
100
|
| '==' is not preceded with whitespace. |
100
|
| '==' is not followed by whitespace. |
100
|
| Line has trailing spaces. |
102
|
| 'for' is not followed by whitespace. |
107
|
| '=' is not preceded with whitespace. |
107
|
| '=' is not followed by whitespace. |
107
|
| ';' is not followed by whitespace. |
107
|
| '<' is not preceded with whitespace. |
107
|
| '<' is not followed by whitespace. |
107
|
| ';' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
109
|
| '+' is not followed by whitespace. |
109
|
| '+' is not preceded with whitespace. |
109
|
| '+' is not followed by whitespace. |
109
|
| '+' is not preceded with whitespace. |
109
|
| '+' is not followed by whitespace. |
109
|
| ')' is preceded with whitespace. |
110
|
| Line has trailing spaces. |
113
|
| 'if' is not followed by whitespace. |
113
|
| '==' is not preceded with whitespace. |
113
|
| '==' is not followed by whitespace. |
113
|
| '==' is not preceded with whitespace. |
113
|
| '==' is not followed by whitespace. |
113
|
| Line contains a tab character. |
113
|
| Line is longer than 80 characters. |
114
|
| '+' is not preceded with whitespace. |
114
|
| '+' is not followed by whitespace. |
114
|
| Line has trailing spaces. |
115
|
| 'if' is not followed by whitespace. |
118
|
| '==' is not preceded with whitespace. |
118
|
| '==' is not followed by whitespace. |
118
|
| '==' is not preceded with whitespace. |
118
|
| '==' is not followed by whitespace. |
118
|
| Line has trailing spaces. |
122
|
| 'if' is not followed by whitespace. |
123
|
| Line is longer than 80 characters. |
124
|
| '+' is not preceded with whitespace. |
124
|
| '+' is not followed by whitespace. |
124
|
| '}' should be on the same line. |
126
|
| Line has trailing spaces. |
129
|
| Line has trailing spaces. |
134
|
| First sentence should end with a period. |
141
|
| Line has trailing spaces. |
141
|
| Line has trailing spaces. |
144
|
| Expected an @return tag. |
148
|
| Line has trailing spaces. |
148
|
| Parameter mfile should be final. |
148
|
| Expected @param tag for 'mfile'. |
148
|
| Expected @throws tag for 'IOException'. |
149
|
| 'mappings' hides a field. |
153
|
| '50' is a magic number. |
153
|
| Line has trailing spaces. |
158
|
| 'while' is not followed by whitespace. |
162
|
| '(' is followed by whitespace. |
162
|
| '(' is followed by whitespace. |
164
|
| '||' should be on a new line. |
164
|
| '(' is followed by whitespace. |
165
|
| ')' is preceded with whitespace. |
165
|
| Line has trailing spaces. |
169
|
| Line has trailing spaces. |
187
|
| Line has trailing spaces. |
190
|
| Line has trailing spaces. |
191
|
| Line has trailing spaces. |
192
|
| '16' is a magic number. |
192
|
| 'while' is not followed by whitespace. |
193
|
| ')' is preceded with whitespace. |
193
|
| 'if' is not followed by whitespace. |
196
|
| 'for' is not followed by whitespace. |
198
|
| '=' is not preceded with whitespace. |
198
|
| '=' is not followed by whitespace. |
198
|
| ';' is not followed by whitespace. |
198
|
| '<' is not preceded with whitespace. |
198
|
| '<' is not followed by whitespace. |
198
|
| ';' is not followed by whitespace. |
198
|
| '=' is not preceded with whitespace. |
199
|
| '=' is not followed by whitespace. |
199
|
| 'cast' is not followed by whitespace. |
199
|
| Line is longer than 80 characters. |
206
|
| Line has trailing spaces. |
207
|
| Line has trailing spaces. |
211
|
| 'if' construct must use '{}'s. |
213
|
| Line has trailing spaces. |
214
|
| Missing a Javadoc comment. |
227
|
| Missing a Javadoc comment. |
229
|
| Missing a Javadoc comment. |
230
|
| Missing a Javadoc comment. |
231
|
| Missing a Javadoc comment. |
233
|
| Parameter str should be final. |
233
|
| 'str' hides a field. |
233
|
| Missing a Javadoc comment. |
239
|
| Missing a Javadoc comment. |
243
|
| 'if' construct must use '{}'s. |
248
|
| '-' is not preceded with whitespace. |
250
|
| '-' is not followed by whitespace. |
250
|
| '=' is not preceded with whitespace. |
255
|
| '=' is not followed by whitespace. |
255
|
| ';' is not followed by whitespace. |
255
|
| '<' is not preceded with whitespace. |
255
|
| '<' is not followed by whitespace. |
255
|
| ';' is not followed by whitespace. |
255
|
| '(' is followed by whitespace. |
261
|
| ')' is preceded with whitespace. |
261
|
| '=' is not preceded with whitespace. |
269
|
| '=' is not followed by whitespace. |
269
|
| ';' is not followed by whitespace. |
269
|
| '<' is not preceded with whitespace. |
269
|
| '<' is not followed by whitespace. |
269
|
| ';' is not followed by whitespace. |
269
|
| Missing a Javadoc comment. |
283
|
| Missing a Javadoc comment. |
287
|
| Missing a Javadoc comment. |
295
|
| 'while' is not followed by whitespace. |
298
|
| '(' is followed by whitespace. |
298
|
| ')' is preceded with whitespace. |
298
|
org/opensciencegrid/authz/service/SAMLAuthZServiceBase.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
5
|
| Unused import - org.glite.security.SecurityContext. |
15
|
| Unused import - org.glite.security.util.axis.InitSecurityContext. |
16
|
| Line has trailing spaces. |
48
|
| Comment matches to-do format 'TODO:'. |
55
|
| Line has trailing spaces. |
56
|
| First sentence should end with a period. |
63
|
| Line has trailing spaces. |
66
|
| First sentence should end with a period. |
67
|
| Line has trailing spaces. |
67
|
| Line is longer than 80 characters. |
68
|
| Line has trailing spaces. |
71
|
| Variable 'decision' must be private and have accessor methods. |
71
|
| Line has trailing spaces. |
72
|
| First sentence should end with a period. |
73
|
| Line has trailing spaces. |
73
|
| Variable 'actions' must be private and have accessor methods. |
74
|
| First sentence should end with a period. |
76
|
| Line is longer than 80 characters. |
76
|
| Variable 'obligations' must be private and have accessor methods. |
77
|
| Line has trailing spaces. |
78
|
| First sentence should end with a period. |
79
|
| Line is longer than 80 characters. |
79
|
| Variable 'issuer' must be private and have accessor methods. |
80
|
| First sentence should end with a period. |
82
|
| Expected an @return tag. |
83
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
83
|
| '+' is not preceded with whitespace. |
85
|
| '+' is not followed by whitespace. |
85
|
| 'if' construct must use '{}'s. |
87
|
| 'if' is not followed by whitespace. |
87
|
| '==' is not preceded with whitespace. |
87
|
| '==' is not followed by whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| '=' is not preceded with whitespace. |
87
|
| '=' is not followed by whitespace. |
87
|
| 'if' construct must use '{}'s. |
88
|
| 'if' is not followed by whitespace. |
88
|
| '=' is not preceded with whitespace. |
88
|
| 'else' construct must use '{}'s. |
89
|
| 'for' is not followed by whitespace. |
90
|
| '=' is not preceded with whitespace. |
90
|
| '=' is not followed by whitespace. |
90
|
| ';' is not followed by whitespace. |
90
|
| '<' is not preceded with whitespace. |
90
|
| '<' is not followed by whitespace. |
90
|
| ';' is not followed by whitespace. |
90
|
| Line has trailing spaces. |
91
|
| '=' is not preceded with whitespace. |
94
|
| '=' is not followed by whitespace. |
94
|
| '+' is not preceded with whitespace. |
94
|
| '+' is not followed by whitespace. |
94
|
| '+' is not preceded with whitespace. |
94
|
| '+' is not followed by whitespace. |
94
|
| '+' is not preceded with whitespace. |
94
|
| '+' is not followed by whitespace. |
94
|
| '}' should be on the same line. |
95
|
| 'else' construct must use '{}'s. |
96
|
| '=' is not preceded with whitespace. |
97
|
| '+' is not preceded with whitespace. |
97
|
| '+' is not followed by whitespace. |
97
|
| '=' is not preceded with whitespace. |
99
|
| '=' is not followed by whitespace. |
99
|
| 'if' construct must use '{}'s. |
100
|
| 'if' is not followed by whitespace. |
100
|
| '==' is not preceded with whitespace. |
100
|
| '==' is not followed by whitespace. |
100
|
| '=' is not preceded with whitespace. |
100
|
| '=' is not followed by whitespace. |
100
|
| 'if' construct must use '{}'s. |
101
|
| 'if' is not followed by whitespace. |
101
|
| '=' is not preceded with whitespace. |
101
|
| 'else' construct must use '{}'s. |
102
|
| 'for' is not followed by whitespace. |
103
|
| '=' is not preceded with whitespace. |
103
|
| '=' is not followed by whitespace. |
103
|
| ';' is not followed by whitespace. |
103
|
| '<' is not preceded with whitespace. |
103
|
| '<' is not followed by whitespace. |
103
|
| ';' is not followed by whitespace. |
103
|
| Line has trailing spaces. |
104
|
| Line is longer than 80 characters. |
107
|
| '=' is not preceded with whitespace. |
107
|
| '=' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
107
|
| '+' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
107
|
| '+' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
107
|
| '+' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
107
|
| '+' is not followed by whitespace. |
107
|
| '+' is not preceded with whitespace. |
107
|
| '+' is not followed by whitespace. |
107
|
| '}' should be on the same line. |
108
|
| 'else' construct must use '{}'s. |
109
|
| '=' is not preceded with whitespace. |
110
|
| '+' is not preceded with whitespace. |
112
|
| '+' is not followed by whitespace. |
112
|
| First sentence should end with a period. |
118
|
| Line is longer than 80 characters. |
118
|
| Missing a Javadoc comment. |
120
|
| Variable 'issuer' must be private and have accessor methods. |
120
|
| Missing a Javadoc comment. |
121
|
| Variable 'data' must be private and have accessor methods. |
121
|
| First sentence should end with a period. |
127
|
| Line has trailing spaces. |
127
|
| Line is longer than 80 characters. |
127
|
| Line is longer than 80 characters. |
128
|
| Line has trailing spaces. |
129
|
| Line is longer than 80 characters. |
130
|
| ',' is not followed by whitespace. |
130
|
| Line is longer than 80 characters. |
131
|
| Missing a Javadoc comment. |
131
|
| ',' is not followed by whitespace. |
131
|
| First sentence should end with a period. |
133
|
| Line has trailing spaces. |
133
|
| Line is longer than 80 characters. |
133
|
| First sentence should end with a period. |
136
|
| Line is longer than 80 characters. |
137
|
| Variable 'log' must be private and have accessor methods. |
137
|
| ')' is preceded with whitespace. |
137
|
| Line has trailing spaces. |
139
|
| Line is longer than 80 characters. |
141
|
| Line has trailing spaces. |
147
|
| Line is longer than 80 characters. |
147
|
| Line is longer than 80 characters. |
150
|
| Line is longer than 80 characters. |
151
|
| Line is longer than 80 characters. |
153
|
| Line has trailing spaces. |
158
|
| Expected an @return tag. |
161
|
| Line is longer than 80 characters. |
161
|
| Parameter subject should be final. |
161
|
| Expected @param tag for 'subject'. |
161
|
| Parameter resource should be final. |
161
|
| Expected @param tag for 'resource'. |
161
|
| Parameter actions should be final. |
161
|
| Expected @param tag for 'actions'. |
161
|
| Parameter evidence should be final. |
161
|
| Expected @param tag for 'evidence'. |
161
|
| Expected @throws tag for 'SAMLException'. |
162
|
| Line has trailing spaces. |
165
|
| Line has trailing spaces. |
167
|
| Line has trailing spaces. |
168
|
| Line is longer than 80 characters. |
168
|
| Line has trailing spaces. |
171
|
| Line is longer than 80 characters. |
171
|
| Line is longer than 80 characters. |
172
|
| Expected an @return tag. |
175
|
| Line is longer than 80 characters. |
175
|
| Method 'SAMLRequest' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Method length is 174 lines (max allowed is 150). |
175
|
| Name 'SAMLRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
175
|
| Parameter samlRequestType should be final. |
175
|
| Expected @param tag for 'samlRequestType'. |
175
|
| Expected @throws tag for 'java.rmi.RemoteException'. |
175
|
| Line has trailing spaces. |
176
|
| Line has trailing spaces. |
185
|
| Line is longer than 80 characters. |
186
|
| Line is longer than 80 characters. |
189
|
| Line is longer than 80 characters. |
193
|
| Line has trailing spaces. |
198
|
| Line has trailing spaces. |
199
|
| Line has trailing spaces. |
200
|
| Line has trailing spaces. |
201
|
| Line has trailing spaces. |
202
|
| Line has trailing spaces. |
209
|
| Line has trailing spaces. |
224
|
| Line is longer than 80 characters. |
224
|
| Line is longer than 80 characters. |
227
|
| Line has trailing spaces. |
228
|
| 'if' construct must use '{}'s. |
230
|
| Line is longer than 80 characters. |
230
|
| 'if' is not followed by whitespace. |
230
|
| '!=' is not preceded with whitespace. |
230
|
| '!=' is not followed by whitespace. |
230
|
| Line has trailing spaces. |
231
|
| Line is longer than 80 characters. |
234
|
| Line has trailing spaces. |
235
|
| Line has trailing spaces. |
236
|
| Line contains a tab character. |
236
|
| '(' is followed by whitespace. |
236
|
| Line has trailing spaces. |
237
|
| Line contains a tab character. |
237
|
| Line has trailing spaces. |
238
|
| Line contains a tab character. |
238
|
| Line contains a tab character. |
239
|
| '+' is not preceded with whitespace. |
241
|
| '!=' is not followed by whitespace. |
247
|
| '&&' should be on a new line. |
247
|
| '(' is followed by whitespace. |
248
|
| '||' should be on a new line. |
248
|
| '||' should be on a new line. |
249
|
| Line has trailing spaces. |
250
|
| ')' is preceded with whitespace. |
250
|
| Must have at least one statement. |
251
|
| '}' should be on the same line. |
253
|
| Line has trailing spaces. |
254
|
| Line has trailing spaces. |
255
|
| Line is longer than 80 characters. |
256
|
| Line has trailing spaces. |
258
|
| 'if' construct must use '{}'s. |
259
|
| Line has trailing spaces. |
259
|
| Line is longer than 80 characters. |
260
|
| Line has trailing spaces. |
261
|
| 'if' construct must use '{}'s. |
262
|
| '==' is not followed by whitespace. |
262
|
| Line is longer than 80 characters. |
263
|
| Line has trailing spaces. |
264
|
| Line has trailing spaces. |
265
|
| Line is longer than 80 characters. |
266
|
| Line is longer than 80 characters. |
267
|
| Line has trailing spaces. |
269
|
| 'if' is not followed by whitespace. |
269
|
| '(' is followed by whitespace. |
269
|
| '!=' is not preceded with whitespace. |
269
|
| '!=' is not followed by whitespace. |
269
|
| Line has trailing spaces. |
270
|
| Line contains a tab character. |
270
|
| Line contains a tab character. |
271
|
| ')' is preceded with whitespace. |
271
|
| Line is longer than 80 characters. |
274
|
| Line has trailing spaces. |
275
|
| Line is longer than 80 characters. |
275
|
| Line is longer than 80 characters. |
276
|
| Line has trailing spaces. |
282
|
| Line has trailing spaces. |
283
|
| Line has trailing spaces. |
284
|
| Line is longer than 80 characters. |
284
|
| '+' is not preceded with whitespace. |
284
|
| Line is longer than 80 characters. |
286
|
| Line is longer than 80 characters. |
288
|
| Line has trailing spaces. |
290
|
| '(' is followed by whitespace. |
290
|
| Line contains a tab character. |
291
|
| Line has trailing spaces. |
292
|
| Line contains a tab character. |
292
|
| Line contains a tab character. |
293
|
| Line has trailing spaces. |
301
|
| Line is longer than 80 characters. |
301
|
| Line has trailing spaces. |
302
|
| Line is longer than 80 characters. |
303
|
| '+' is not preceded with whitespace. |
304
|
| '+' is not followed by whitespace. |
304
|
| ',' is not followed by whitespace. |
305
|
| Line is longer than 80 characters. |
307
|
| 'if' construct must use '{}'s. |
308
|
| '==' is not preceded with whitespace. |
308
|
| '==' is not followed by whitespace. |
308
|
| Line is longer than 80 characters. |
311
|
| 'while' construct must use '{}'s. |
313
|
| Line has trailing spaces. |
313
|
| 'while' is not followed by whitespace. |
313
|
| 'if' construct must use '{}'s. |
315
|
| '=' is not preceded with whitespace. |
315
|
| '=' is not followed by whitespace. |
315
|
| Line has trailing spaces. |
316
|
| Line is longer than 80 characters. |
316
|
| Line is longer than 80 characters. |
317
|
| Line has trailing spaces. |
318
|
| '(' is followed by whitespace. |
318
|
| Line contains a tab character. |
319
|
| Line has trailing spaces. |
320
|
| Line contains a tab character. |
320
|
| Line contains a tab character. |
321
|
| Line is longer than 80 characters. |
323
|
| Line is longer than 80 characters. |
327
|
| '+' is not preceded with whitespace. |
328
|
| '+' is not followed by whitespace. |
328
|
| ',' is not followed by whitespace. |
328
|
| Line has trailing spaces. |
330
|
| Line is longer than 80 characters. |
330
|
| Line is longer than 80 characters. |
331
|
| Line is longer than 80 characters. |
332
|
| Line is longer than 80 characters. |
333
|
| '}' should be on the same line. |
335
|
| Line is longer than 80 characters. |
337
|
| '+' is not preceded with whitespace. |
340
|
| '+' is not followed by whitespace. |
340
|
| ',' is not followed by whitespace. |
340
|
| Line is longer than 80 characters. |
341
|
| First sentence should end with a period. |
353
|
| Line has trailing spaces. |
353
|
| Expected an @return tag. |
356
|
| Parameter requestType should be final. |
356
|
| Expected @param tag for 'requestType'. |
356
|
| Expected @throws tag for 'RemoteException'. |
357
|
| Expected @throws tag for 'SAMLException'. |
357
|
| Line has trailing spaces. |
358
|
| Line is longer than 80 characters. |
381
|
| '+' is not preceded with whitespace. |
381
|
| '+' is not followed by whitespace. |
381
|
| First sentence should end with a period. |
390
|
| Line has trailing spaces. |
392
|
| Expected an @return tag. |
397
|
| Parameter request should be final. |
397
|
| Expected @param tag for 'request'. |
397
|
| Expected @throws tag for 'RemoteException'. |
398
|
| Expected @throws tag for 'SAMLException'. |
398
|
| ')' is preceded with whitespace. |
408
|
| Line is longer than 80 characters. |
409
|
| Line has trailing spaces. |
414
|
| Line has trailing spaces. |
415
|
| 'cast' is not followed by whitespace. |
417
|
| ')' is preceded with whitespace. |
419
|
| '+' is not preceded with whitespace. |
421
|
| '+' is not followed by whitespace. |
421
|
| Line has trailing spaces. |
422
|
| '}' should be on the same line. |
422
|
| ')' is preceded with whitespace. |
423
|
| '+' is not preceded with whitespace. |
425
|
| '+' is not followed by whitespace. |
425
|
| '}' should be on the same line. |
426
|
| Line is longer than 80 characters. |
428
|
| '+' is not preceded with whitespace. |
428
|
| '+' is not followed by whitespace. |
428
|
| Line is longer than 80 characters. |
433
|
| Line is longer than 80 characters. |
434
|
| First sentence should end with a period. |
446
|
| Expected an @return tag. |
449
|
| Line is longer than 80 characters. |
449
|
| Parameter request should be final. |
449
|
| Expected @param tag for 'request'. |
449
|
| Expected @throws tag for 'RemoteException'. |
450
|
| Expected @throws tag for 'SAMLException'. |
450
|
| ')' is preceded with whitespace. |
453
|
| '+' is not preceded with whitespace. |
454
|
| '+' is not followed by whitespace. |
454
|
| '+' is not preceded with whitespace. |
457
|
| '+' is not followed by whitespace. |
457
|
| Expected an @return tag. |
468
|
| Parameter subject should be final. |
468
|
| Expected @param tag for 'subject'. |
468
|
| Expected @throws tag for 'SAMLException'. |
469
|
| Line has trailing spaces. |
473
|
| Line has trailing spaces. |
474
|
| First sentence should end with a period. |
476
|
| Line is longer than 80 characters. |
476
|
| Expected an @return tag. |
480
|
| Line is longer than 80 characters. |
480
|
| Parameter query should be final. |
480
|
| Expected @param tag for 'query'. |
480
|
| Parameter decision should be final. |
481
|
| Expected @param tag for 'decision'. |
481
|
| Line contains a tab character. |
482
|
| Parameter actions should be final. |
482
|
| Expected @param tag for 'actions'. |
482
|
| Parameter obligations should be final. |
483
|
| Expected @param tag for 'obligations'. |
483
|
| Expected @throws tag for 'SAMLException'. |
484
|
| Line has trailing spaces. |
485
|
| Line contains a tab character. |
486
|
| Line contains a tab character. |
487
|
| Line has trailing spaces. |
488
|
| 'if' construct must use '{}'s. |
489
|
| Line is longer than 80 characters. |
489
|
| 'if' is not followed by whitespace. |
489
|
| '(' is followed by whitespace. |
489
|
| '!=' is not preceded with whitespace. |
489
|
| '!=' is not followed by whitespace. |
489
|
| ')' is preceded with whitespace. |
489
|
| ')' is preceded with whitespace. |
489
|
| Line contains a tab character. |
491
|
| 'else' construct must use '{}'s. |
496
|
| Line contains a tab character. |
498
|
| Line has trailing spaces. |
502
|
| Line has trailing spaces. |
504
|
| Line has trailing spaces. |
507
|
| Line has trailing spaces. |
510
|
| Line has trailing spaces. |
512
|
| First sentence should end with a period. |
514
|
| Expected an @return tag. |
519
|
| Parameter issuer should be final. |
519
|
| Expected @param tag for 'issuer'. |
519
|
| Parameter stmts should be final. |
519
|
| Expected @param tag for 'stmts'. |
519
|
| Expected @throws tag for 'SAMLException'. |
520
|
| Line has trailing spaces. |
524
|
| Line has trailing spaces. |
528
|
| Line has trailing spaces. |
531
|
| Line has trailing spaces. |
532
|
| Line contains a tab character. |
532
|
| Line has trailing spaces. |
533
|
| Line contains a tab character. |
533
|
| Line contains a tab character. |
534
|
| Line has trailing spaces. |
535
|
| Line has trailing spaces. |
542
|
| First sentence should end with a period. |
544
|
| Line has trailing spaces. |
544
|
| Expected an @return tag. |
546
|
| Line has trailing spaces. |
546
|
| Parameter inResponseTo should be final. |
546
|
| Expected @param tag for 'inResponseTo'. |
546
|
| Line has trailing spaces. |
547
|
| Line contains a tab character. |
547
|
| Parameter recipient should be final. |
547
|
| Expected @param tag for 'recipient'. |
547
|
| Line has trailing spaces. |
548
|
| Line contains a tab character. |
548
|
| Parameter assertions should be final. |
548
|
| Expected @param tag for 'assertions'. |
548
|
| Line contains a tab character. |
549
|
| Parameter samlException should be final. |
549
|
| Expected @param tag for 'samlException'. |
549
|
| Expected @throws tag for 'SAMLException'. |
550
|
| Line is longer than 80 characters. |
554
|
| '+' is not preceded with whitespace. |
556
|
| '+' is not followed by whitespace. |
556
|
| Line is longer than 80 characters. |
560
|
| '{' is followed by whitespace. |
560
|
| 'cast' is not followed by whitespace. |
560
|
| First sentence should end with a period. |
568
|
| Line has trailing spaces. |
569
|
| Expected an @return tag. |
573
|
| Method 'getFQAN' is not designed for extension - needs to be abstract, final or empty. |
573
|
| Parameter stmt should be final. |
573
|
| Expected @param tag for 'stmt'. |
573
|
| Expected @throws tag for 'SAMLException'. |
573
|
| '(' is followed by whitespace. |
581
|
| '!' is followed by whitespace. |
581
|
| ')' is preceded with whitespace. |
581
|
| '}' should be on the same line. |
583
|
| 'cast' is not followed by whitespace. |
585
|
| 'cast' is not followed by whitespace. |
586
|
| Line is longer than 80 characters. |
587
|
| '+' is not preceded with whitespace. |
587
|
| '+' is not followed by whitespace. |
587
|
| '+' is not preceded with whitespace. |
587
|
| '+' is not preceded with whitespace. |
587
|
| '+' is not followed by whitespace. |
587
|
| Line is longer than 80 characters. |
589
|
| '(' is followed by whitespace. |
589
|
| ')' is preceded with whitespace. |
589
|
| '(' is followed by whitespace. |
590
|
| 'if' construct must use '{}'s. |
595
|
| 'if' is not followed by whitespace. |
595
|
| '!=' is not preceded with whitespace. |
595
|
| '!=' is not followed by whitespace. |
595
|
| '+' is not preceded with whitespace. |
595
|
| '+' is not followed by whitespace. |
595
|
| 'else' construct must use '{}'s. |
596
|
| Line is longer than 80 characters. |
596
|
| Expected an @return tag. |
608
|
| Line is longer than 80 characters. |
608
|
| Method 'findFQANinSubjectEvidence' is not designed for extension - needs to be abstract, final or empty. |
608
|
| Parameter evidenceIterator should be final. |
608
|
| Expected @param tag for 'evidenceIterator'. |
608
|
| Parameter querySubject should be final. |
608
|
| Expected @param tag for 'querySubject'. |
608
|
| Expected @throws tag for 'SAMLException'. |
609
|
| '(' is followed by whitespace. |
617
|
| Line is longer than 80 characters. |
619
|
| 'cast' is not followed by whitespace. |
619
|
| Line is longer than 80 characters. |
623
|
| 'cast' is not followed by whitespace. |
623
|
| ')' is preceded with whitespace. |
623
|
| ')' is preceded with whitespace. |
623
|
| '=' is not preceded with whitespace. |
625
|
| '=' is not followed by whitespace. |
625
|
| 'cast' is not followed by whitespace. |
625
|
| Line is longer than 80 characters. |
626
|
| 'if' is not followed by whitespace. |
627
|
| '!=' is not preceded with whitespace. |
627
|
| '!=' is not followed by whitespace. |
627
|
| First sentence should end with a period. |
642
|
| Line has trailing spaces. |
643
|
| Expected an @return tag. |
646
|
| Line is longer than 80 characters. |
646
|
| Method 'locatePermissibleActions' is not designed for extension - needs to be abstract, final or empty. |
646
|
| Parameter requestedActions should be final. |
646
|
| Expected @param tag for 'requestedActions'. |
646
|
| Parameter permissibleActionsList should be final. |
646
|
| Expected @param tag for 'permissibleActionsList'. |
646
|
| Line has trailing spaces. |
651
|
| Line is longer than 80 characters. |
652
|
| 'cast' is not followed by whitespace. |
654
|
| 'for' is not followed by whitespace. |
656
|
| '=' is not preceded with whitespace. |
656
|
| '=' is not followed by whitespace. |
656
|
| ';' is not followed by whitespace. |
656
|
| '<' is not preceded with whitespace. |
656
|
| '<' is not followed by whitespace. |
656
|
| ';' is not followed by whitespace. |
656
|
| 'cast' is not followed by whitespace. |
657
|
| Line has trailing spaces. |
658
|
| 'if' is not followed by whitespace. |
661
|
| ',' is not followed by whitespace. |
661
|
| ')' is preceded with whitespace. |
661
|
| Line is longer than 80 characters. |
662
|
| '+' is not preceded with whitespace. |
662
|
| '+' is not followed by whitespace. |
662
|
| Line is longer than 80 characters. |
663
|
| Line is longer than 80 characters. |
665
|
| Line is longer than 80 characters. |
666
|
| 'if' construct must use '{}'s. |
677
|
| ')' is preceded with whitespace. |
677
|
| Line has trailing spaces. |
678
|
| Line has trailing spaces. |
679
|
| Line has trailing spaces. |
680
|
| Line has trailing spaces. |
682
|
| First sentence should end with a period. |
685
|
| Expected an @return tag. |
688
|
| Parameter attrib should be final. |
688
|
| Expected @param tag for 'attrib'. |
688
|
| Expected @throws tag for 'SAMLException'. |
689
|
| 'cast' is not followed by whitespace. |
692
|
| 'if' is not followed by whitespace. |
695
|
| '(' is followed by whitespace. |
695
|
| '!' is followed by whitespace. |
695
|
| Line has trailing spaces. |
699
|
| Line has trailing spaces. |
706
|
org/opensciencegrid/authz/service/SecurityUtil.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Utility classes should not have a public or default constructor. |
23
|
| Missing a Javadoc comment. |
24
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
26
|
| 'if' construct must use '{}'s. |
34
|
| Line is longer than 80 characters. |
43
|
| '+' is not preceded with whitespace. |
43
|
| '+' is not followed by whitespace. |
43
|
| Line has trailing spaces. |
46
|
| Missing a Javadoc comment. |
47
|
| Parameter commaDN should be final. |
47
|
| '+' is not preceded with whitespace. |
52
|
| '+' is not followed by whitespace. |
52
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
57
|
| Line has trailing spaces. |
64
|
org/opensciencegrid/authz/service/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/opensciencegrid/authz/stubs/AuthorizationService.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Redundant 'public' modifier. |
13
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| Redundant 'public' modifier. |
15
|
| Line is longer than 80 characters. |
17
|
| Missing a Javadoc comment. |
17
|
| Redundant 'public' modifier. |
17
|
org/opensciencegrid/authz/stubs/AuthorizationServiceBindingImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| '{' is not preceded with whitespace. |
10
|
| Line is longer than 80 characters. |
11
|
| Method 'SAMLRequest' is not designed for extension - needs to be abstract, final or empty. |
11
|
| Missing a Javadoc comment. |
11
|
| Name 'SAMLRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
11
|
| Parameter samlRequest should be final. |
11
|
org/opensciencegrid/authz/stubs/AuthorizationServiceBindingSkeleton.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Name '_myOperations' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
12
|
| Line is longer than 80 characters. |
13
|
| Missing a Javadoc comment. |
13
|
| Name '_myOperationsList' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
13
|
| First sentence should end with a period. |
15
|
| Expected an @return tag. |
18
|
| Line is longer than 80 characters. |
18
|
| Parameter methodName should be final. |
18
|
| Expected @param tag for 'methodName'. |
18
|
| 'cast' is not followed by whitespace. |
19
|
| First sentence should end with a period. |
22
|
| Expected an @return tag. |
25
|
| Name '_oper' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
30
|
| Name '_fault' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
31
|
| Name '_params' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
32
|
| Line has trailing spaces. |
34
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
39
|
| 'cast' is not followed by whitespace. |
44
|
| Missing a Javadoc comment. |
47
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
51
|
| Missing a Javadoc comment. |
51
|
| Parameter impl should be final. |
51
|
| 'impl' hides a field. |
51
|
| Line is longer than 80 characters. |
54
|
| Method 'SAMLRequest' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Name 'SAMLRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
| Parameter samlRequest should be final. |
54
|
| Line is longer than 80 characters. |
56
|
org/opensciencegrid/authz/stubs/AuthorizationServiceBindingStub.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Name '_operations' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
16
|
| Variable '_operations' must be private and have accessor methods. |
16
|
| Line is longer than 80 characters. |
23
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
25
|
| Missing a Javadoc comment. |
33
|
| Line is longer than 80 characters. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter endpointURL should be final. |
37
|
| Parameter service should be final. |
37
|
| Line is longer than 80 characters. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter service should be final. |
42
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
81
|
| Missing a Javadoc comment. |
81
|
| Name '_call' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
83
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
120
|
| '}' should be on the same line. |
130
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
136
|
| Method 'SAMLRequest' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Missing a Javadoc comment. |
136
|
| Name 'SAMLRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
136
|
| Parameter samlRequest should be final. |
136
|
| Name '_call' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
140
|
| Line is longer than 80 characters. |
143
|
| Line is longer than 80 characters. |
145
|
| Line is longer than 80 characters. |
146
|
| Line is longer than 80 characters. |
147
|
| Line is longer than 80 characters. |
148
|
| Line is longer than 80 characters. |
152
|
| Name '_resp' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
152
|
| 'cast' is not followed by whitespace. |
155
|
| '}' should be on the same line. |
156
|
| Name '_exception' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
161
|
| Line is longer than 80 characters. |
162
|
org/opensciencegrid/authz/stubs/AuthorizationServiceLocator.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| Name 'AuthorizationServicePort_address' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
15
|
| Method 'getAuthorizationServicePortAddress' is not designed for extension - needs to be abstract, final or empty. |
17
|
| Missing a Javadoc comment. |
17
|
| Line is longer than 80 characters. |
22
|
| Missing a Javadoc comment. |
22
|
| Name 'AuthorizationServicePortWSDDServiceName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
22
|
| Method 'getAuthorizationServicePortWSDDServiceName' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Line is longer than 80 characters. |
28
|
| Method 'setAuthorizationServicePortWSDDServiceName' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter name should be final. |
28
|
| Line is longer than 80 characters. |
32
|
| Method 'getAuthorizationServicePort' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| '}' should be on the same line. |
36
|
| Line is longer than 80 characters. |
43
|
| Method 'getAuthorizationServicePort' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Parameter portAddress should be final. |
43
|
| Line is longer than 80 characters. |
45
|
| Name '_stub' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| '}' should be on the same line. |
48
|
| Expected an @return tag. |
59
|
| Line is longer than 80 characters. |
59
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Parameter serviceEndpointInterface should be final. |
59
|
| Expected @param tag for 'serviceEndpointInterface'. |
59
|
| Expected @throws tag for 'javax.xml.rpc.ServiceException'. |
59
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
62
|
| Name '_stub' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
62
|
| '}' should be on the same line. |
66
|
| Line is longer than 80 characters. |
70
|
| Avoid inline conditionals. |
70
|
| Expected an @return tag. |
78
|
| Line is longer than 80 characters. |
78
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Parameter portName should be final. |
78
|
| Expected @param tag for 'portName'. |
78
|
| Parameter serviceEndpointInterface should be final. |
78
|
| Expected @param tag for 'serviceEndpointInterface'. |
78
|
| Expected @throws tag for 'javax.xml.rpc.ServiceException'. |
78
|
| '}' should be on the same line. |
85
|
| Name '_stub' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
87
|
| Method 'getServiceName' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Line is longer than 80 characters. |
94
|
| Missing a Javadoc comment. |
97
|
| Method 'getPorts' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Missing a Javadoc comment. |
99
|
| Line is longer than 80 characters. |
102
|
org/opensciencegrid/authz/stubs/SAMLRequestPortType.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
10
|
| Line is longer than 80 characters. |
11
|
| Missing a Javadoc comment. |
11
|
| Redundant 'public' modifier. |
11
|
| Name 'SAMLRequest' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
11
|
org/opensciencegrid/authz/stubs/SAMLRequestType.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Name '_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
11
|
| Missing a Javadoc comment. |
13
|
| Method 'get_any' is not designed for extension - needs to be abstract, final or empty. |
16
|
| Missing a Javadoc comment. |
16
|
| Name 'get_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
16
|
| Method 'set_any' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Name 'set_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
20
|
| Parameter _any should be final. |
20
|
| '_any' hides a field. |
20
|
| Name '_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
20
|
| Missing a Javadoc comment. |
24
|
| Name '__equalsCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
24
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter obj should be final. |
25
|
| 'if' construct must use '{}'s. |
26
|
| 'if' construct must use '{}'s. |
28
|
| 'if' construct must use '{}'s. |
29
|
| Name '_equals' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Line has trailing spaces. |
35
|
| '&&' should be on a new line. |
35
|
| Expression can be simplified. |
35
|
| Line has trailing spaces. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '||' should be on a new line. |
36
|
| '!=' is not preceded with whitespace. |
37
|
| '!=' is not followed by whitespace. |
37
|
| '&&' should be on a new line. |
37
|
| Missing a Javadoc comment. |
43
|
| Name '__hashCodeCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Name '_hashCode' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| '=' is not preceded with whitespace. |
51
|
| '=' is not followed by whitespace. |
51
|
| '<' is not preceded with whitespace. |
52
|
| '<' is not followed by whitespace. |
52
|
| Line is longer than 80 characters. |
54
|
| '&&' should be on a new line. |
55
|
| Missing a Javadoc comment. |
66
|
| Line is longer than 80 characters. |
70
|
| First sentence should end with a period. |
73
|
| Expected an @return tag. |
76
|
| First sentence should end with a period. |
80
|
| Expected an @return tag. |
83
|
| Line has trailing spaces. |
84
|
| Parameter mechType should be final. |
84
|
| Expected @param tag for 'mechType'. |
84
|
| Line has trailing spaces. |
85
|
| Parameter _javaType should be final. |
85
|
| Expected @param tag for '_javaType'. |
85
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
85
|
| Parameter _xmlType should be final. |
86
|
| Expected @param tag for '_xmlType'. |
86
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
86
|
| Line has trailing spaces. |
87
|
| First sentence should end with a period. |
92
|
| Expected an @return tag. |
95
|
| Line has trailing spaces. |
96
|
| Parameter mechType should be final. |
96
|
| Expected @param tag for 'mechType'. |
96
|
| Line has trailing spaces. |
97
|
| Parameter _javaType should be final. |
97
|
| Expected @param tag for '_javaType'. |
97
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
97
|
| Parameter _xmlType should be final. |
98
|
| Expected @param tag for '_xmlType'. |
98
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
98
|
| Line has trailing spaces. |
99
|
org/opensciencegrid/authz/stubs/SAMLResponseType.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Name '_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
11
|
| Missing a Javadoc comment. |
13
|
| Method 'get_any' is not designed for extension - needs to be abstract, final or empty. |
16
|
| Missing a Javadoc comment. |
16
|
| Name 'get_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
16
|
| Method 'set_any' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Name 'set_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
20
|
| Parameter _any should be final. |
20
|
| '_any' hides a field. |
20
|
| Name '_any' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
20
|
| Missing a Javadoc comment. |
24
|
| Name '__equalsCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
24
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter obj should be final. |
25
|
| 'if' construct must use '{}'s. |
26
|
| 'if' construct must use '{}'s. |
28
|
| 'if' construct must use '{}'s. |
29
|
| Name '_equals' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Line has trailing spaces. |
35
|
| '&&' should be on a new line. |
35
|
| Expression can be simplified. |
35
|
| Line has trailing spaces. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '||' should be on a new line. |
36
|
| '!=' is not preceded with whitespace. |
37
|
| '!=' is not followed by whitespace. |
37
|
| '&&' should be on a new line. |
37
|
| Missing a Javadoc comment. |
43
|
| Name '__hashCodeCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Name '_hashCode' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| '=' is not preceded with whitespace. |
51
|
| '=' is not followed by whitespace. |
51
|
| '<' is not preceded with whitespace. |
52
|
| '<' is not followed by whitespace. |
52
|
| Line is longer than 80 characters. |
54
|
| '&&' should be on a new line. |
55
|
| Missing a Javadoc comment. |
66
|
| Line is longer than 80 characters. |
70
|
| First sentence should end with a period. |
73
|
| Expected an @return tag. |
76
|
| First sentence should end with a period. |
80
|
| Expected an @return tag. |
83
|
| Line has trailing spaces. |
84
|
| Parameter mechType should be final. |
84
|
| Expected @param tag for 'mechType'. |
84
|
| Line has trailing spaces. |
85
|
| Parameter _javaType should be final. |
85
|
| Expected @param tag for '_javaType'. |
85
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
85
|
| Parameter _xmlType should be final. |
86
|
| Expected @param tag for '_xmlType'. |
86
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
86
|
| Line has trailing spaces. |
87
|
| First sentence should end with a period. |
92
|
| Expected an @return tag. |
95
|
| Line has trailing spaces. |
96
|
| Parameter mechType should be final. |
96
|
| Expected @param tag for 'mechType'. |
96
|
| Line has trailing spaces. |
97
|
| Parameter _javaType should be final. |
97
|
| Expected @param tag for '_javaType'. |
97
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
97
|
| Parameter _xmlType should be final. |
98
|
| Expected @param tag for '_xmlType'. |
98
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
98
|
| Line has trailing spaces. |
99
|
org/opensciencegrid/authz/stubs/_SAMLRequestResponse.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
10
|
| Name '_SAMLRequestResponse' must match pattern '^[A-Z][a-zA-Z0-9]*$'. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Method 'getSamlResponse' is not designed for extension - needs to be abstract, final or empty. |
16
|
| Missing a Javadoc comment. |
16
|
| Line is longer than 80 characters. |
20
|
| Method 'setSamlResponse' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Parameter samlResponse should be final. |
20
|
| 'samlResponse' hides a field. |
20
|
| Missing a Javadoc comment. |
24
|
| Name '__equalsCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
24
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter obj should be final. |
25
|
| 'if' construct must use '{}'s. |
26
|
| 'if' construct must use '{}'s. |
28
|
| 'if' construct must use '{}'s. |
29
|
| Name '_equals' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
| Line has trailing spaces. |
35
|
| '&&' should be on a new line. |
35
|
| Expression can be simplified. |
35
|
| Line has trailing spaces. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '==' is not preceded with whitespace. |
36
|
| '==' is not followed by whitespace. |
36
|
| '||' should be on a new line. |
36
|
| '!=' is not preceded with whitespace. |
37
|
| '!=' is not followed by whitespace. |
37
|
| '&&' should be on a new line. |
37
|
| Missing a Javadoc comment. |
43
|
| Name '__hashCodeCalc' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
43
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Name '_hashCode' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| Missing a Javadoc comment. |
58
|
| Line is longer than 80 characters. |
62
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
66
|
| First sentence should end with a period. |
70
|
| Expected an @return tag. |
73
|
| First sentence should end with a period. |
77
|
| Expected an @return tag. |
80
|
| Line has trailing spaces. |
81
|
| Parameter mechType should be final. |
81
|
| Expected @param tag for 'mechType'. |
81
|
| Line has trailing spaces. |
82
|
| Parameter _javaType should be final. |
82
|
| Expected @param tag for '_javaType'. |
82
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
82
|
| Parameter _xmlType should be final. |
83
|
| Expected @param tag for '_xmlType'. |
83
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
83
|
| Line has trailing spaces. |
84
|
| First sentence should end with a period. |
89
|
| Expected an @return tag. |
92
|
| Line has trailing spaces. |
93
|
| Parameter mechType should be final. |
93
|
| Expected @param tag for 'mechType'. |
93
|
| Line has trailing spaces. |
94
|
| Parameter _javaType should be final. |
94
|
| Expected @param tag for '_javaType'. |
94
|
| Name '_javaType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
94
|
| Parameter _xmlType should be final. |
95
|
| Expected @param tag for '_xmlType'. |
95
|
| Name '_xmlType' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
95
|
| Line has trailing spaces. |
96
|
org/opensciencegrid/authz/stubs/package.html
Error | Line |
| Missing package documentation file. | 0 |